Expand rocket launch data#84
Merged
Merged
Conversation
thompson318
reviewed
May 20, 2026
Member
thompson318
left a comment
There was a problem hiding this comment.
Looks good and works for me (with a small change for when using the mouse). Output csv looks correct and refactoring of speed and steadiness calculations is good.
A couple of minor comments re naming plus one thing that needs fixing when detecting player out of range when using the mouse instead of tracker.
Collaborator
Author
|
Thanks for the comments @thompson318 ! - I think I've added all of those fixes now, so ready to review again 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #20
Expands rocket launch data, see extra clarifications from David at: #20 (comment) (also older comments at: #20 (comment) - most have been superseded, except that requiring 'Only measuring measuring their head speed with gaze on target')
Some extra notes:
samplingIntervalSeconds. I've kept this parameter separate from thespeedTime/gazeTimeused for the main gameplay, so these can be adjusted separately.