St/style checks #41
Merged
St/style checks #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Meech
reviewed
Jan 22, 2026
Collaborator
K-Meech
left a comment
K-Meech
left a comment
There was a problem hiding this comment.
Thanks for setting this up @thompson318 ! I've put some minor comments below.
I tried running it locally with prek, but had an error relating to .NET - so potentially an extra step is needed in the instructions for running locally?
Merged
thompson318
force-pushed
the
st/style-checks
branch
from
9bb5c69 to
0874231
Compare
Member
Author
|
@K-Meech this should be ready for re-review now. |
K-Meech
approved these changes
Jan 27, 2026
Collaborator
There was a problem hiding this comment.
Thanks @thompson318 - looks good to me! I can run this locally now with no issues 👍
One minor comment below - I only needed to install .NET SDK manually, pre-commit handled the CSharpier install automatically.
Also, there are a few merge conflicts at the moment, so you may need to run CSharpier again.
Co-authored-by: Kimberly Meechan <24316371+K-Meech@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #7. Adds a github action to check style using csharpier, along with a pre-commit that can be used locally to automatically fix style.