Make even more strings translatable and fix some others #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app.cpp -- Make message box translatable subtitle.cpp -- Make message boxes translatable timecode.cpp -- Make message box translatable
dialog_fonts_collector.cpp -- Make "Zip Archives" string translatable dialog_kara_timing_copy.cpp -- Change window title and remove dot in checkbox dialog_search_replace.cpp -- Make message box title translatable dialog_shift_times.cpp -- Make "shift amount" plural dialog_video_details.cpp -- Change singular "1 frame" to "1 frame (%s)" (to avoid having similar translations for dialog_shift_times and dialog_video_details) main.cpp -- Make message boxes translatable video_controller.cpp -- Make log errors translatable video_display.cpp -- Make log errors translatable
Missed a "Text files" string in save file selector
video_controller.cpp -- Remove line breaker auto4_lua.cpp -- Make warning/error logs translatable
.......sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think right now everything is translatable except for Lua stuff and logging (and I still don't know how to squash, sorry)