Raise an error when config file is specified but not found#1514
Closed
Y-- wants to merge 1 commit intoTypeStrong:mainfrom
Closed
Raise an error when config file is specified but not found#1514Y-- wants to merge 1 commit intoTypeStrong:mainfrom
Y-- wants to merge 1 commit intoTypeStrong:mainfrom
Conversation
Member
|
Thanks for contributing! Is the logic for your check definitely correct? if (loaderOptions.configFile !== undefined) { // should this be === undefined?
configFileError = new Error(`Cannot find '${loaderOptions.configFile }' in folder '${path.dirname(loader.resourcePath)}'`);
} |
Author
Well I want to throw an error if there is a file specified by the user (i.e. not Basically I spent quite some time understanding why my config changes were not taken into account until I realized the file referenced in the loader did not exist, and the loader was instead creating a default configuration :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
A small contribution to explicitly raise an error if user specify a configuration file that cannot be resolved/found.
Please let me know:
formatErrorsutils but didn't seem to work in this case)Thanks!!