-
-
Notifications
You must be signed in to change notification settings - Fork 660
feat: allow customizing the rendering of video and audio elements #2203 #2250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
YousefED
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, couple of questions to nail this:
- should we use the name
render? (it's a term we use in other places as well, so might get confusing? Or good for consistency?) - Can we add a simple test for this?
- Do we want to implement this at the React layer (React File blocks) as well? Or rather first determine what our strategy is in the react vs native file blocks?
🤷 I haven't got a better name at the moment.
Of course.
Now that you mention this, I think this might go a bit deeper, whether this is working towards or against the idea of separating the schema config from it's rendering. Like maybe a user could choose to override the rendering to put whatever they want instead. |
Summary
An attempt to supercede #2229
Rationale
Changes
Impact
Testing
Screenshots/Video
Checklist
Additional Notes
Resolves #2203