Skip to content

feat(methodology): Rule 10 — Output language English (Layer-0)#107

Merged
sgwannabe merged 1 commit intomainfrom
feat/output-language-policy
Apr 26, 2026
Merged

feat(methodology): Rule 10 — Output language English (Layer-0)#107
sgwannabe merged 1 commit intomainfrom
feat/output-language-policy

Conversation

@sgwannabe
Copy link
Copy Markdown
Contributor

Summary

Adds Rule 10 to plugins/preview-forge/methodology/global.md enforcing English-only user-facing output from all 144 plugin agents. Closes the gap that #102 didn't cover — #102 was archive cleanup (CONTRIBUTING + 23 issue translations), but did not constrain what users actually see when they invoke the plugin.

What changed

  • New Rule 10 added after Rule 9 in methodology/global.md. Covers AskUserQuestion modals, console prose, status messages, Gate H1/H2 labels, user-readable generated artifacts.
  • Rationale, single-turn override exception, and scope clarification (rule constrains output, not the language of the agent's own markdown prompt).
  • Section title updated 7개 비협상 규칙Layer-0 비협상 규칙 (count was already stale because Rules 8/9 were added in v1.2/v1.3).
  • 불변 원칙 footer acknowledges Rules 1-10.

Why this is enough (no per-agent edit needed)

All 144 agents already include @methodology/global.md in their Layer-0 directive at the top of their frontmatter. Adding a rule to that single file propagates the constraint to every agent automatically. No need to touch each agent file individually.

Side effects

  • No code change in any script, hook, or agent prompt
  • No advocate boilerplate changetests/test-advocate-boilerplate.sh still passes (lint scope is agents/ideation/advocates/P*.md, not methodology/)
  • bash scripts/verify-plugin.sh → 58 Pass / 0 Fail
  • No new fixture — natural-language output enforcement is hard to lint deterministically; PR body notes that a future Hangul-codepoint scanner hook is tracked separately

Test plan

  • bash scripts/verify-plugin.sh → Pass 58/0
  • grep verification: rule landed at the right anchor in global.md
  • Manual e2e (recommended after merge + plugin update): run /pf:new "..." in Korean and verify the AskUserQuestion modals appear in English

Codex review

Skipped — single-file documentation rule addition, zero code surface, no behavior change.

Refs #102

User-facing output from any of the 144 plugin agents (AskUserQuestion
modal labels, console prose, status messages, Gate H1/H2 modals,
generated artifacts the user reads directly) MUST be in English. Korean
prompts from the user are not a switch signal — agents reply in English
by default. Single-turn override only via explicit per-turn directive.

Why: the repo's archive (commits, PR bodies, code, schemas, root
CHANGELOG) is English-only per CONTRIBUTING.md "Language" section. A
bilingual user surface breaks searchability for non-Korean reviewers
and contradicts the documented policy.

Scope: this rule constrains the *output the agent emits to the user*,
not the language of the agent's own markdown prompt (which may stay in
Korean for maintenance — many existing agent prompts are Korean).

Enforcement: Layer-0 rule, propagated to all 144 agents via
`@methodology/global.md`. factory-policy.py does not parse
natural-language output, so enforcement is by agent compliance. A
future hook may scan AskUserQuestion payloads for Hangul code points
and warn — tracked separately.

Side effects:
- Updates section title from "7개 비협상 규칙" to neutral
  "Layer-0 비협상 규칙" (count was already stale — Rules 8 and 9 were
  added later)
- Updates the 불변 원칙 footer to acknowledge Rules 1-10
- No agent file modified — the rule reaches all agents via the
  existing @methodology/global.md include in their frontmatter
- verify-plugin.sh: still 58/0

Refs #102 (closing the gap that #102 didn't cover — endusers' actual
plugin output language)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Warning

Rate limit exceeded

@sgwannabe has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 46 minutes and 55 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 55 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ba287b42-2b75-4f0c-bba7-6e498e2151a6

📥 Commits

Reviewing files that changed from the base of the PR and between dcaeb8a and a398c8f.

📒 Files selected for processing (1)
  • plugins/preview-forge/methodology/global.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/output-language-policy

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sgwannabe sgwannabe merged commit 3dda141 into main Apr 26, 2026
7 checks passed
@sgwannabe sgwannabe deleted the feat/output-language-policy branch April 26, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant