Open
Conversation
Stupid annoying code don't use yet pls
Stupid
Added Command struct for more succinct token checks. Removed unnecessary files. Moved directory setting & checks from main into separate function. Added Task 4 work for cd'ing into a directory
Simply needed to malloc the size to command and use strcpy to get copy of string instead of direct reference because tokenizeInput destroys input strings
Added error fix in executeHistory function
Added saveHistory and loadHistory functions to history.c, and added a bit to exitProgram in commands.c so that the history is saved and memory returned before exiting. (THIS IS ALL UNTESTED)
…ID JULY) Code has been commented but is only partially functional. I encountered an issue where if I change directory when using our shell, the hist_list.txt file ends up saved in that directory instead of home, resulting in the loadHistory function failing and a blank history being created.
Fixed the bug where it was saving a new history file in whatever the cwd was instead of the same place each time. Used the same code that forces the shell to home directory. Then it saves there, the same place it loads from every time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making main up to date with current task for testing