add tests #1
Open
add tests #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nopilei
reviewed
Sep 19, 2023
|
|
||
|
|
||
| @pytest.fixture() | ||
| def settings() -> Settings: |
There was a problem hiding this comment.
Плагин pytest-django предоставляет фикстуру settings, которая возвращает настройки, поэтому по идее такая фикстура не нужна
|
|
||
|
|
||
| @pytest.fixture() | ||
| def create_lead_api_user_response() -> UserResponseFactory: |
There was a problem hiding this comment.
Фикстуру если она просто что-то возвращает лучше назвать без глагола, то есть lead_api_user_response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
К сожалению, не хватило времени сделать больше
Поэтому основой целью(план минимум) для себя поставил - попробовать поработать с
httpretty, так как раньше не сталкивался и не повторять код из лекции(то есть не тестировать регистрацию)Исключил из покрытия html шаблоны, итоговое покрытие получилось следующим
полностью оказались покрыты два файла:
server/apps/identity/logic/usecases/user_create_new.pyиserver/apps/identity/views/user.py