Refactor AnnotatingVisitor to use dedicated visitor method for loop annotations#702
Draft
michaelos443 wants to merge 1 commit into
Draft
Refactor AnnotatingVisitor to use dedicated visitor method for loop annotations#702michaelos443 wants to merge 1 commit into
michaelos443 wants to merge 1 commit into
Conversation
…d in AnnotatingVisitor
|
Started — view session to follow along. |
|
Started — view session to follow along. |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors
AnnotatingVisitorinvyper/vyper/ast/parse.pyto replace the unreliable "fake_node" manipulation with a dedicated_parse_for_annotationmethod.Changes:
AnnotatingVisitor._parse_for_annotationto cleanly constructpython_ast.AnnAssignfrom pre-parser tokens.visit_Forto delegate annotation parsing._deepcopy_asthelper andpickleimport.Validation:
tests/functional/syntax/test_for_range.pypassed.Pull Request opened by Augment Code | View session