refactor(idurar-erp-crm): remove unused utils helpers and dead Redux crud selectors#692
Draft
augmentcode[bot] wants to merge 1 commit into
Draft
refactor(idurar-erp-crm): remove unused utils helpers and dead Redux crud selectors#692augmentcode[bot] wants to merge 1 commit into
augmentcode[bot] wants to merge 1 commit into
Conversation
…crud selectors - Delete utils/tagColor.js — never imported anywhere - helpers.js: remove has, toFormData, formatDate, isDate, formatDatetime, and Object.byString side-effect (only valueByString and validatePhoneNumber are used) - valueType.js: keep only isObject (only consumer); drop isFunction, isString, isBoolean, isNumber, isUndef - color.js: drop selectColor named export (only default color array is imported) - dataStructure.jsx: drop unexported getRandomColor helper (dead internal code) - redux/crud/selectors.js: remove selectItemById and selectReadItem (neither is imported anywhere in the codebase; erp equivalents are active)
Author
|
👋 I've got this PR — here's what I'll handle for you:
Marking it ready and picking reviewers are your call — I'll leave both alone. Drop a comment anytime! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Author Agent⚡
Summary
Pure dead-code removal in
idurar-erp-crm/frontend— no behaviour changes, no new dependencies.frontend/src/utilstagColor.jshelpers.jshas,toFormData,formatDate,isDate,formatDatetime, and theObject.byStringprototype side-effect; keptvalueByStringandvalidatePhoneNumber(both imported)valueType.jsisObject(used inuseNetwork.jsx); removedisFunction,isString,isBoolean,isNumber,isUndefcolor.jsselectColornamed export (nothing imports it); defaultcolorarray keptdataStructure.jsxgetRandomColorhelper (defined but never called)frontend/src/redux/crud/selectors.jsRemoved
selectItemByIdandselectReadItem— confirmed bygrepthat no file in the frontend imports either from this module. (The same-named selectors inredux/erp/selectors.jsare actively used and untouched.)Verification
After the removals, the following grep queries return zero results in
frontend/src/:All existing imports (
valueByString,validatePhoneNumber,isObject,isBrowser,tagColorfromstatusTagColor,calculate,color,countryList,currencyList,dataForTable,dataForRead) continue to resolve correctly.Pull Request opened by Augment Code | View session