refactor: move docstring handling in AnnotatingVisitor to mixin#691
Draft
augmentcode[bot] wants to merge 1 commit into
Draft
refactor: move docstring handling in AnnotatingVisitor to mixin#691augmentcode[bot] wants to merge 1 commit into
augmentcode[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
AnnotatingVisitorinparse.pyhandles location annotation, docstring promotion, keyword translation, and numeric literal parsing all in one large class.This PR extracts the docstring promotion logic into a separate
_DocstringVisitorMixinto improve modularity and readability.Changes:
_DocstringVisitorMixininvyper/ast/parse.py.AnnotatingVisitorto inherit from_DocstringVisitorMixin.ModuleandFunctionDefare still correctly promoted and annotated.Pull Request opened by Augment Code | View session