Use renovate-config repo directly for Renovate presets#220
Open
ErisDS wants to merge 1 commit into
Open
Conversation
For a while, Renovate recommended using the .github repo to store shared presets. In our case, that setup is mostly just an alias to renovate-config, and it adds indirection and confusion about what our standard source should be. Going forward, we don't want to use the .github repo for this. Having a dedicated renovate-config repo is more intuitive, so this switches to the direct preset source and standardizes where shared Renovate config comes from.
WalkthroughThe Renovate configuration in package.json has been updated to change the extend target from "@TryGhost:quietJS" to "github>TryGhost/renovate-config". This is a single-line configuration modification with no functional code changes. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Line 47: The Renovate preset reference in package.json changed from the
npm-style "@tryghost:quietJS" to "github>TryGhost/renovate-config", which loads
the repo default (quiet.json5) not the named quietJS preset; either update the
dependency preset string to the explicit named form
"github>TryGhost/renovate-config:quietJS" if you want to preserve the original
quietJS behavior, or review/compare the settings in quiet.json5 vs quietJS to
confirm they produce identical Renovate behavior and adjust package.json
accordingly (look for the preset entry value "github>TryGhost/renovate-config"
and the old "@tryghost:quietJS" reference).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tryghost:preset usage withgithub>TryGhost/renovate-config