Fix: Add proper error handling for file read errors in load_file()#316
Closed
prjanitor wants to merge 1 commit intoTruncateGame:mainfrom
Closed
Fix: Add proper error handling for file read errors in load_file()#316prjanitor wants to merge 1 commit intoTruncateGame:mainfrom
prjanitor wants to merge 1 commit intoTruncateGame:mainfrom
Conversation
…ve message on file read errors
|
Closing this PR -- after a closer review, we believe this change isn't correct. Apologies for the noise; we're still ironing out some kinks in our automated flow. Thanks for your patience! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
load_file()function instorage.rswas using.unwrap_or_default()to silently ignore file read errors. This could hide critical issues such as:seed_notes.ymlfileThis made debugging difficult and could lead to unexpected behavior when the notes file was missing or inaccessible.
Solution
Changed
.unwrap_or_default()to.expect("seed_notes.yml file must exist and be readable")to properly surface file read errors with a descriptive error message. This ensures that:Testing
The fix ensures that any file read error will now cause the program to panic with a clear error message, making it easier to identify and resolve issues with the seed notes file.
This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.