refactor(acp-nats-agent): use imported names instead of inline full paths#87
Merged
refactor(acp-nats-agent): use imported names instead of inline full paths#87
Conversation
…aths Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview Tightens JetStream handling by switching several Adds small unit tests in Written by Cursor Bugbot for commit 696d541. This will update automatically on new commits. Configure here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughRefactored imports in the connection module to use locally imported acp_nats helpers/types; adjusted JetStream request/response subject construction and ReqId parsing; simplified ack/cancel error handling to log via inspector calls; added unit tests for PromptResponse/Update subjects and new JetStream cancel/ack failure tests. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 696d541 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
…::future::ready Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
… warn paths Cover three previously-uncovered code paths: - Add ToSubject tests for UpdateSubject and PromptResponseSubject - Add cancel NotificationHandler error + ack failure test (covers inspect_err closure and session_id warn field) - Replace dead inline closures in no_reply_subject/bad_payload tests with a named init_handler_error helper, and add a test that actually calls it Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acp_nats::...::Typepath expressions in function bodies into theuseblock at the top ofconnection.rsReqId,PromptResponseSubject, andResponseSubject