Skip to content

chore(http): remove subscription stream listing#161

Merged
yordis merged 5 commits intomasterfrom
yordis/chore-remove-subscriptions-stream-http
May 3, 2026
Merged

chore(http): remove subscription stream listing#161
yordis merged 5 commits intomasterfrom
yordis/chore-remove-subscriptions-stream-http

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 3, 2026

  • Persistent subscription stream listings already have a gRPC management path, so retaining the HTTP read route keeps duplicate management surface area alive without preserving unique capability.

yordis added 5 commits May 3, 2026 02:34
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 3, 2026

PR Summary

Medium Risk
Removes the GET /subscriptions/{stream} HTTP route, which is a breaking change for any clients depending on per-stream subscription listing; core logic is otherwise unchanged.

Overview
Removes the per-stream persistent subscription listing HTTP endpoint (GET /subscriptions/{stream}) from PersistentSubscriptionController, leaving only GET /subscriptions (and /info for a specific group) for read access.

Updates test coverage and API surface accordingly: deletes HTTP long-running tests targeting the removed route, adjusts HTTP authorization expectations, prunes the route from swagger.yaml, and adds a gRPC test asserting List on a missing stream returns NotFound.

Reviewed by Cursor Bugbot for commit 2e78afc. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3ec0ced4-1fc4-49e1-b0ea-7a66736a93d6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-remove-subscriptions-stream-http

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from yordis/chore-remove-subscriptions-delete-http to master May 3, 2026 17:30
@yordis yordis merged commit 6835496 into master May 3, 2026
18 checks passed
@yordis yordis deleted the yordis/chore-remove-subscriptions-stream-http branch May 3, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant