Skip to content

chore(storage): remove LogV3#154

Merged
yordis merged 2 commits intomasterfrom
yordis/chore-remove-logv3
May 3, 2026
Merged

chore(storage): remove LogV3#154
yordis merged 2 commits intomasterfrom
yordis/chore-remove-logv3

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 3, 2026

  • Narrows the storage surface to the supported log format so future cleanup and migration work has fewer experimental branches to keep alive.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Important

Review skipped

Too many files!

This PR contains 300 files, which is 150 over the limit of 150.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e174eada-f391-41b2-93a9-e0f8d7cc3b0c

📥 Commits

Reviewing files that changed from the base of the PR and between a499b57 and 1bd9b9e.

📒 Files selected for processing (300)
  • ci/ci.runsettings
  • scripts/test.sh
  • src/Directory.Packages.props
  • src/EventStore.ClusterNode/ClusterVNodeHostedService.cs
  • src/EventStore.Common/Options/DbLogFormat.cs
  • src/EventStore.Core.Tests/Authentication/when_handling_multiple_requests_with_reset_password_cache_in_between.cs
  • src/EventStore.Core.Tests/Authentication/when_handling_multiple_requests_with_the_same_correct_user_name_and_password.cs
  • src/EventStore.Core.Tests/AwakeService/when_handling_comitted_event.cs
  • src/EventStore.Core.Tests/AwakeService/when_handling_committed_event_after_unsybscribe.cs
  • src/EventStore.Core.Tests/AwakeService/when_handling_committed_event_with_subscribers.cs
  • src/EventStore.Core.Tests/AwakeService/when_subscribing_before_last_position_with_already_committed_events.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/append_to_stream_with_event_numbers_greater_than_2_billion.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/catchup_subscription_to_all_with_event_numbers_greater_than_2_billion.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/persistent_subscription_with_event_numbers_greater_than_2_billion.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/read_stream_with_event_numbers_greater_than_2_billion.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/read_stream_with_link_to_event_with_event_number_greater_than_int_maxvalue.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/subscribe_to_stream_with_link_to_event_with_event_number_greater_than_int_maxvalue.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/subscriptions_on_stream_with_event_numbers_greater_than_2_billion.cs
  • src/EventStore.Core.Tests/ClientAPI/ExpectedVersion64Bit/transactions_on_stream_with_event_numbers_greater_than_2_billion.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/all_stream_with_no_acl_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/authorized_default_credentials_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/delete_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/multiple_role_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/overriden_system_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/overriden_system_stream_security_for_all.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/overriden_user_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/read_all_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/read_stream_meta_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/read_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/stream_security_inheritance.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/subscribe_to_all_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/subscribe_to_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/system_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/transactional_write_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/write_stream_meta_security.cs
  • src/EventStore.Core.Tests/ClientAPI/Security/write_stream_security.cs
  • src/EventStore.Core.Tests/ClientAPI/UserManagement/creating_a_user.cs
  • src/EventStore.Core.Tests/ClientAPI/UserManagement/deleting_a_user.cs
  • src/EventStore.Core.Tests/ClientAPI/UserManagement/enable_disable_user.cs
  • src/EventStore.Core.Tests/ClientAPI/UserManagement/get_current_user.cs
  • src/EventStore.Core.Tests/ClientAPI/UserManagement/list_users.cs
  • src/EventStore.Core.Tests/ClientAPI/UserManagement/reset_change_password.cs
  • src/EventStore.Core.Tests/ClientAPI/UserManagement/updating_a_user.cs
  • src/EventStore.Core.Tests/ClientAPI/append_to_stream.cs
  • src/EventStore.Core.Tests/ClientAPI/append_to_stream_with_hash_collision.cs
  • src/EventStore.Core.Tests/ClientAPI/appending_to_implicitly_created_stream.cs
  • src/EventStore.Core.Tests/ClientAPI/appending_to_implicitly_created_stream_using_transaction.cs
  • src/EventStore.Core.Tests/ClientAPI/appending_to_streams_across_restart.cs
  • src/EventStore.Core.Tests/ClientAPI/catchup_filtered_subscription.cs
  • src/EventStore.Core.Tests/ClientAPI/catchup_subscription_handles_small_batch_sizes.cs
  • src/EventStore.Core.Tests/ClientAPI/connect.cs
  • src/EventStore.Core.Tests/ClientAPI/connecting_to_a_persistent_subscription.cs
  • src/EventStore.Core.Tests/ClientAPI/connecting_to_a_persistent_subscription_async.cs
  • src/EventStore.Core.Tests/ClientAPI/connecting_with_connection_string.cs
  • src/EventStore.Core.Tests/ClientAPI/create_persistent_subscription.cs
  • src/EventStore.Core.Tests/ClientAPI/deleting_persistent_subscription.cs
  • src/EventStore.Core.Tests/ClientAPI/deleting_stream.cs
  • src/EventStore.Core.Tests/ClientAPI/event_store_connection_should.cs
  • src/EventStore.Core.Tests/ClientAPI/isjson_flag_on_event.cs
  • src/EventStore.Core.Tests/ClientAPI/persistent_connect_integration_tests.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_backward_filtered_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_backward_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_filtered_paging_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_forward_filtered_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_forward_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_forward_with_hard_deleted_stream_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_forward_with_linkto_passed_max_count.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_forward_with_linkto_to_deleted_event.cs
  • src/EventStore.Core.Tests/ClientAPI/read_all_events_forward_with_soft_deleted_stream_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_allevents_backward_with_linkto_deleted_event.cs
  • src/EventStore.Core.Tests/ClientAPI/read_event_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_event_stream_backward_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_event_stream_forward_should.cs
  • src/EventStore.Core.Tests/ClientAPI/read_event_with_hash_collision.cs
  • src/EventStore.Core.Tests/ClientAPI/read_from_persistent_subscription_with_link_resolution_when_stream_name_contains_at_symbol.cs
  • src/EventStore.Core.Tests/ClientAPI/read_stream_events_backward_with_hash_collision.cs
  • src/EventStore.Core.Tests/ClientAPI/read_stream_events_forward_with_hash_collision.cs
  • src/EventStore.Core.Tests/ClientAPI/read_stream_events_with_unresolved_linkto.cs
  • src/EventStore.Core.Tests/ClientAPI/soft_delete.cs
  • src/EventStore.Core.Tests/ClientAPI/subscribe_should.cs
  • src/EventStore.Core.Tests/ClientAPI/subscribe_to_all_catching_up_should.cs
  • src/EventStore.Core.Tests/ClientAPI/subscribe_to_all_filtered_should.cs
  • src/EventStore.Core.Tests/ClientAPI/subscribe_to_all_should.cs
  • src/EventStore.Core.Tests/ClientAPI/subscribe_to_stream_catching_up_should.cs
  • src/EventStore.Core.Tests/ClientAPI/transaction.cs
  • src/EventStore.Core.Tests/ClientAPI/update_persistent_subscription.cs
  • src/EventStore.Core.Tests/ClientAPI/when_committing_empty_transaction.cs
  • src/EventStore.Core.Tests/ClientAPI/when_having_max_count_set_for_stream.cs
  • src/EventStore.Core.Tests/ClientAPI/when_having_truncatebefore_set_for_stream.cs
  • src/EventStore.Core.Tests/ClientAPI/when_working_with_metadata.cs
  • src/EventStore.Core.Tests/ClientAPI/when_working_with_stream_metadata_as_byte_array.cs
  • src/EventStore.Core.Tests/ClientAPI/when_working_with_stream_metadata_as_structured_info.cs
  • src/EventStore.Core.Tests/ClientOperations/when_committing_a_transaction_with_data.cs
  • src/EventStore.Core.Tests/ClientOperations/when_starting_a_transaction_expecting_no_stream.cs
  • src/EventStore.Core.Tests/ClientOperations/when_starting_a_transaction_expecting_version_any.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/QueueWriteEventsTests/when_a_write_completes.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/QueueWriteEventsTests/when_requesting_multiple_writes_with_different_keys.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/QueueWriteEventsTests/when_requesting_multiple_writes_with_the_same_key.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/ReadEventsTests/async_read_stream_events_backward_with_cancelled_read.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/ReadEventsTests/async_read_stream_events_forward_with_cancelled_read.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/ReadEventsTests/read_stream_events_backward_with_successful_read.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/ReadEventsTests/read_stream_events_backward_with_timeout_on_read.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/ReadEventsTests/read_stream_events_forward_with_successful_read.cs
  • src/EventStore.Core.Tests/Helpers/IODispatcherTests/ReadEventsTests/read_stream_events_forward_with_timeout_on_read.cs
  • src/EventStore.Core.Tests/Http/ArgumentPassing/matching.cs
  • src/EventStore.Core.Tests/Http/BasicAuthentication/basic_authentication.cs
  • src/EventStore.Core.Tests/Http/HealthChecks/when_performing_a_live_check.cs
  • src/EventStore.Core.Tests/Http/Info/when_getting_options.cs
  • src/EventStore.Core.Tests/Http/PersistentSubscription/creating.cs
  • src/EventStore.Core.Tests/Http/PersistentSubscription/deleting.cs
  • src/EventStore.Core.Tests/Http/PersistentSubscription/statistics.cs
  • src/EventStore.Core.Tests/Http/PersistentSubscription/updating.cs
  • src/EventStore.Core.Tests/Http/Users/users.cs
  • src/EventStore.Core.Tests/Integration/Idempotency/when_soft_deleted_stream_is_written_to_idempotently.cs
  • src/EventStore.Core.Tests/Integration/authenticated_requests_made_from_a_follower.cs
  • src/EventStore.Core.Tests/Integration/when_a_leader_is_shutdown.cs
  • src/EventStore.Core.Tests/Integration/when_a_single_node_is_restarted_multiple_times.cs
  • src/EventStore.Core.Tests/Integration/when_a_single_node_is_shutdown.cs
  • src/EventStore.Core.Tests/Integration/when_cluster_nodes_are_restarted.cs
  • src/EventStore.Core.Tests/Integration/when_node_becomes_leader_with_unindexed_data.cs
  • src/EventStore.Core.Tests/LogFormatHelper.cs
  • src/EventStore.Core.Tests/Services/IndexCommitter/when_index_commiter_service_receives_replicated_to_prepare_post_position.cs
  • src/EventStore.Core.Tests/Services/IndexCommitter/when_index_committer_service_receives_duplicate_commit_acks.cs
  • src/EventStore.Core.Tests/Services/IndexCommitter/when_index_committer_service_receives_multiple_acks_for_different_positions.cs
  • src/EventStore.Core.Tests/Services/IndexCommitter/when_index_committer_service_receives_multiple_acks_for_different_positions_out_of_order.cs
  • src/EventStore.Core.Tests/Services/IndexCommitter/when_index_committer_service_receives_replicated_lower_position.cs
  • src/EventStore.Core.Tests/Services/IndexCommitter/when_index_committer_service_receives_replicated_to_prepare_pre_position.cs
  • src/EventStore.Core.Tests/Services/PersistentSubscription/GetAllPersistentSubscriptionStatsTests.cs
  • src/EventStore.Core.Tests/Services/PersistentSubscription/PersistentSubscriptionMessageParkerTests.cs
  • src/EventStore.Core.Tests/Services/PersistentSubscription/PersistentSubscriptionTests.cs
  • src/EventStore.Core.Tests/Services/PersistentSubscription/when_an_error_occurs.cs
  • src/EventStore.Core.Tests/Services/PersistentSubscription/when_restarting.cs
  • src/EventStore.Core.Tests/Services/RedactionService/EventPositionTests.cs
  • src/EventStore.Core.Tests/Services/RedactionService/LockTests.cs
  • src/EventStore.Core.Tests/Services/RedactionService/SwitchChunkFailureTests.cs
  • src/EventStore.Core.Tests/Services/RedactionService/SwitchChunkSuccessTests.cs
  • src/EventStore.Core.Tests/Services/Replication/LeaderReplication/with_replication_service_and_epoch_manager.cs
  • src/EventStore.Core.Tests/Services/Replication/LogReplication/Tests/data_chunk_replication.cs
  • src/EventStore.Core.Tests/Services/Replication/LogReplication/Tests/data_chunk_replication_with_existing_db.cs
  • src/EventStore.Core.Tests/Services/Replication/LogReplication/Tests/raw_chunk_replication.cs
  • src/EventStore.Core.Tests/Services/Replication/ReadOnlyReplica/connecting_to_read_only_replica.cs
  • src/EventStore.Core.Tests/Services/Replication/Subscriptions/when_subscribed_to_stream_on_leader_and_event_is_replicated_to_followers.cs
  • src/EventStore.Core.Tests/Services/RequestManagement/ReadMgr/when_reading_an_event_committed_on_leader_and_on_followers.cs
  • src/EventStore.Core.Tests/Services/RequestManagement/ReadMgr/when_reading_an_event_from_a_single_node.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_a_single_write_before_the_transaction_is_present.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_a_single_write_is_after_transaction_end_but_before_commit_is_present.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_multiple_single_writes_are_after_transaction_end_but_before_commit_is_present.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_disallowed_streams.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_filtering.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_filtering_and_transactions.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_all_with_last_indexed_set.cs
  • src/EventStore.Core.Tests/Services/Storage/AllReader/when_reading_from_stream_which_is_disallowed_from_all.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_duplicate_events_in_a_stream.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_multiple_events_in_a_stream.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_non_zero_capacity.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_prepares_and_commits.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_prepares_and_commits_for_events_with_version_numbers_greater_than_int_maxvalue.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_prepares_and_commits_for_log_records_of_mixed_versions.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_prepares_but_no_commits.cs
  • src/EventStore.Core.Tests/Services/Storage/BuildingIndex/when_building_an_index_off_tfile_with_two_events_in_stream.cs
  • src/EventStore.Core.Tests/Services/Storage/Chaser/when_chaser_reads_commit_event.cs
  • src/EventStore.Core.Tests/Services/Storage/Chaser/when_chaser_reads_committed_prepare_event.cs
  • src/EventStore.Core.Tests/Services/Storage/Chaser/when_chaser_reads_prepare_event.cs
  • src/EventStore.Core.Tests/Services/Storage/Chaser/when_chaser_reads_system_event.cs
  • src/EventStore.Core.Tests/Services/Storage/CheckCommitStartingAt/when_writing_few_prepares_and_committing_one.cs
  • src/EventStore.Core.Tests/Services/Storage/CheckCommitStartingAt/when_writing_few_prepares_with_same_expected_version_and_committing_one_of_them.cs
  • src/EventStore.Core.Tests/Services/Storage/CheckCommitStartingAt/when_writing_few_prepares_with_same_expected_version_and_not_committing_them.cs
  • src/EventStore.Core.Tests/Services/Storage/CheckCommitStartingAt/when_writing_prepares_in_wrong_order_and_committing_in_right_order.cs
  • src/EventStore.Core.Tests/Services/Storage/CheckCommitStartingAt/when_writing_single_prepare.cs
  • src/EventStore.Core.Tests/Services/Storage/ChunkBoundary/when_writing_events_at_chunk_boundary.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/deleting_stream_tests_1.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/deleting_stream_tests_2.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/deleting_stream_tests_3.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/is_stream_deleted_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_deleting_stream_spanning_through_multiple_chunks_in_db_with_other_streams_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_deleting_stream_spanning_through_multiple_chunks_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_deleting_stream_with_1_hash_collision_and_1_stream_with_other_hash_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_deleting_stream_with_2_hash_collisions_and_mixed_order_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_deleting_stream_with_version_numbers_greater_than_int_maxvalue.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_deleting_the_only_existing_stream_in_db_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_hard_deleting_stream.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_hard_deleting_stream_with_log_version_0.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_reading_deleted_stream.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_reading_deleted_stream_written_with_old_log_record_version.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_writing_delete_prepare_but_no_commit_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/when_writing_few_prepares_on_same_event_number_and_commiting_delete_on_this_version_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/DeletingStream/with_empty_db_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/EpochManager/when_having_TFLog_with_existing_epochs.cs
  • src/EventStore.Core.Tests/Services/Storage/EpochManager/when_having_an_epoch_manager_and_empty_tf_log.cs
  • src/EventStore.Core.Tests/Services/Storage/EpochManager/when_starting_having_TFLog_with_existing_epochs.cs
  • src/EventStore.Core.Tests/Services/Storage/EpochManager/when_starting_having_TFLog_with_no_epochs.cs
  • src/EventStore.Core.Tests/Services/Storage/EpochManager/when_truncating_the_epoch_checkpoint.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_no_hash_collisions_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_single_deleted_event_stream_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_three_collisioned_streams_one_event_each_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_three_collisioned_streams_one_event_each_with_second_stream_deleted_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_three_collisioned_streams_with_different_number_of_events_each_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_three_collisioned_streams_with_different_number_of_events_third_one_deleted_each_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_two_collisioned_streams_one_event_each_first_stream_deleted_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/HashCollisions/with_two_collisioned_streams_one_event_each_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/Idempotency/when_writing_a_second_batch_of_events_after_the_first_batch_has_been_replicated.cs
  • src/EventStore.Core.Tests/Services/Storage/Idempotency/when_writing_a_second_batch_of_events_after_the_first_batch_has_not_yet_been_replicated.cs
  • src/EventStore.Core.Tests/Services/Storage/Idempotency/when_writing_a_second_event_after_the_first_event_has_been_replicated.cs
  • src/EventStore.Core.Tests/Services/Storage/Idempotency/when_writing_a_second_event_after_the_first_event_has_not_yet_been_replicated.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/AfterScavenge/when_having_stream_both_maxage_and_maxcount_specified_with_maxage_more_strict.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/AfterScavenge/when_having_stream_both_maxage_and_maxcount_specified_with_maxcount_more_strict.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/AfterScavenge/when_having_stream_with_maxage_specified.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/AfterScavenge/when_having_stream_with_maxcount_specified.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/AfterScavenge/when_having_stream_with_truncatebefore_specified.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_stream_with_max_age.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_stream_with_max_age_and_max_count_and_max_age_is_more_strict.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_stream_with_max_age_and_max_count_and_max_count_is_more_strict.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_stream_with_max_count.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_stream_with_no_max_age_max_count.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_stream_with_start_from.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_very_long_stream_with_max_age_and_mostly_expired_events.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/ReadRangeAndNextEventNumber/when_reading_very_long_stream_with_max_age_and_some_expired_events.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/when_having_one_stream_with_maxage_and_other_stream_with_maxcount_and_streams_have_same_hash.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/when_having_stream_both_maxage_and_maxcount_specified_with_maxage_more_strict.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/when_having_stream_both_maxage_and_maxcount_specified_with_maxcount_more_strict.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/when_having_stream_with_maxage_specified.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/when_having_stream_with_maxcount_specified.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/when_having_stream_with_maxcount_specified_and_long_transactions_written.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/when_having_stream_with_truncatebefore_specified.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_big_max_age.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_big_max_count.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_big_start_from.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_invalid_max_age_and_normal_max_count.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_invalid_max_count_and_normal_max_age.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_invalid_metadata.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_too_big_max_age.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_too_big_max_age_and_normal_max_count.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_too_big_max_count.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_too_big_max_count_and_normal_max_age.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_too_big_start_from.cs
  • src/EventStore.Core.Tests/Services/Storage/MaxAgeMaxCount/with_truncatebefore_greater_than_int_maxvalue.cs
  • src/EventStore.Core.Tests/Services/Storage/Metastreams/read_index_result_original_stream_exists_tests.cs
  • src/EventStore.Core.Tests/Services/Storage/Metastreams/when_having_deleted_stream_and_no_metastream_metastream_is_declared_deleted_as_well.cs
  • src/EventStore.Core.Tests/Services/Storage/Metastreams/when_having_deleted_stream_its_metastream_is_deleted_as_well.cs
  • src/EventStore.Core.Tests/Services/Storage/Metastreams/when_having_multiple_metaevents_in_metastream_and_read_index_is_set_to_keep_just_last.cs
  • src/EventStore.Core.Tests/Services/Storage/Metastreams/when_having_multiple_metaevents_in_metastream_and_read_index_is_set_to_keep_last_2.cs
  • src/EventStore.Core.Tests/Services/Storage/ReadIndexTestScenario.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/ScavengeLogManager/when_initialising.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_deleting_duplicate_events.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_deleting_single_stream_spanning_through_2_chunks_in_2nd_chunk__in_db_with_3_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_deleting_single_stream_spanning_through_2_chunks_in_db_with_2_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_deleting_single_stream_spanning_through_2_chunks_in_db_with_3_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_having_commit_spanning_multiple_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_running_a_scavenge_from_storage_scavenger.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_scavenging_tfchunk_with_deleted_records.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_scavenging_tfchunk_with_incomplete_chunk.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_scavenging_tfchunk_with_transactions.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_scavenging_tfchunk_with_version0_log_records_and_deleted_records.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_scavenging_tfchunk_with_version0_log_records_using_transactions.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_stream_is_softdeleted_and_temp_and_all_events_and_metaevents_are_in_one_chunk.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_stream_is_softdeleted_and_temp_but_some_events_are_in_multiple_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_stream_is_softdeleted_and_temp_but_some_events_are_in_multiple_chunks_2.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_stream_is_softdeleted_and_temp_but_some_metaevents_are_in_multiple_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_stream_is_softdeleted_and_temp_with_log_version_0_but_some_events_are_in_multiple_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_stream_is_softdeleted_with_log_record_version_0.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_stream_is_softdeleted_with_mixed_log_record_version_0_and_version_1.cs
  • src/EventStore.Core.Tests/Services/Storage/Scavenge/when_writing_delete_prepare_without_commit_on_stream_spanning_through_2_chunks_in_db_with_2_chunks.cs
  • src/EventStore.Core.Tests/Services/Storage/Transactions/when_having_multievent_sequential_write_request_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/Transactions/when_having_two_intermingled_transactions_and_some_uncommited_prepares_in_the_end_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/Transactions/when_having_two_intermingled_transactions_and_some_uncommited_prepares_spanning_few_chunks_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/Transactions/when_having_two_intermingled_transactions_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/Transactions/when_having_two_intermingled_transactions_spanning_few_chunks_read_index_should.cs
  • src/EventStore.Core.Tests/Services/Storage/Transactions/when_rebuilding_index_for_partially_persisted_transaction.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscription.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.AllSubscriptionFiltered.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.ReadAllBackwards.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.ReadAllBackwardsFiltered.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.ReadAllForwards.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.ReadAllForwardsFiltered.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.ReadStreamBackwards.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.ReadStreamForwards.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Enumerators/Enumerator.StreamSubscription.Tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/MonitoringTests/StatsTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/PersistentSubscriptionTests/CreateTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/PersistentSubscriptionTests/GetInfoTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/PersistentSubscriptionTests/ReplayParkedTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/PersistentSubscriptionTests/RestartSubsystemTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/ServerFeaturesTests/ServerFeaturesTest.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/AppendBatchToStreamTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/DeleteTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ReadAllBackwardsFilteredTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ReadAllBackwardsTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ReadAllForwardsFilteredTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ReadStreamsBackwardTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/ReadStreamsForwardTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/SubscribeToAllFilteredTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/SubscribeToAllTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/SubscribeToStreamTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Grpc/StreamsTests/TombstoneTests.cs
  • src/EventStore.Core.Tests/Services/Transport/Http/Authentication/basic_http_authentication_provider.cs
  • src/EventStore.Core.Tests/Services/Transport/Http/Authorization/authorization_tests.cs
  • src/EventStore.Core.Tests/Services/Transport/Http/when_getting_tcp_stats_from_stat_controller.cs
  • src/EventStore.Core.Tests/Services/Transport/Tcp/when_invalid_data_is_sent_over_tcp.cs
  • src/EventStore.Core.Tests/Services/UserManagementService/password_change_notification_reader.cs
  • src/EventStore.Core.Tests/Services/UserManagementService/user_management_service.cs

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-remove-logv3

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 3, 2026

PR Summary

Medium Risk
Medium risk because it removes a previously selectable log format and associated tests/CI configuration, which may impact builds or deployments that still reference V3 settings.

Overview
This PR removes the experimental Log V3 surface area and standardizes the codebase on DbLogFormat.V2 only.

It deletes the ExperimentalV3 option from DbLogFormat, drops the V3 node creation path in ClusterVNodeHostedService (now throws if anything but V2 is configured), and simplifies scavenge support flags/messages.

Tests/CI are updated to stop targeting or filtering V3: V3 TestFixtures and V3-specific conditional assertions/setup are removed, EventStore.LogV3.Tests is dropped from scripts/test.sh, the V3 test filter is removed from ci.runsettings, and the Microsoft.FASTER.Core package reference is removed.

Reviewed by Cursor Bugbot for commit 1bd9b9e. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d791d8b. Configure here.

Comment thread src/EventStore.Core.Tests/LogFormatHelper.cs
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis merged commit 8e747a0 into master May 3, 2026
18 checks passed
@yordis yordis deleted the yordis/chore-remove-logv3 branch May 3, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant