Skip to content

Conversation

@Freed-Wu
Copy link
Contributor

@Freed-Wu Freed-Wu commented Jan 2, 2025

screenshot

https://www.npmjs.com/package/coc-write-good

Refer:
https://github.com/valentjn/vscode-ltex/blob/3d0cb8cd9b4d0dc8ef6c08a4f376767820678cf6/src/extension.ts#L8-L14

Difference is vscode-ltex/coc-ltex uses a customized python script
https://github.com/valentjn/vscode-ltex/blob/3d0cb8cd9b4d0dc8ef6c08a4f376767820678cf6/tools/patchForTarget.py
to patch code
we use c language macro preprocessor cpp

Can you add me to collaborators to maintain the support of coc.nvim?
And I want to add your npm account to collaborators of npm package of coc-write-good due to
most code comes from you.
TIA!

@Freed-Wu Freed-Wu changed the title Support coc-write-good Support (Neo)Vim Jan 2, 2025
@Freed-Wu Freed-Wu changed the title Support (Neo)Vim Support (Neo)Vim by coc.nvim Jan 2, 2025
@Freed-Wu Freed-Wu force-pushed the coc branch 2 times, most recently from 4077779 to 5b9c7e8 Compare January 2, 2025 21:25
@TravisTheTechie
Copy link
Owner

I'm going to have think about this a bit. I'm not super happy how it integrates but I do see what you're thinking about. Though the need to use cpp seems odd to me. Maybe it's JUST for the preprocessor? In general though, I'm not against implementing it in a way that is usable by neo-vim. I'm just not sure I'm prepared to make any explicit support for neo-vim as I'm not a user.

@Freed-Wu Freed-Wu force-pushed the coc branch 3 times, most recently from 12e4c3e to 9388924 Compare January 7, 2025 08:23
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jan 7, 2025

@Freed-Wu Freed-Wu force-pushed the coc branch 5 times, most recently from 7779c22 to 59d10ec Compare January 7, 2025 08:47
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Jan 9, 2025

Any other problem?

@TravisTheTechie
Copy link
Owner

I want to acknowledge I see that you have committed changes. But I'm a bit behind on other things right and it will be a couple days before I dive in.

@TravisTheTechie
Copy link
Owner

neoclide/coc.nvim#5244

I'm doing some testing and clean up, depending on time, I'd like to have this cleaned up and done by end of week.

@TravisTheTechie
Copy link
Owner

Alright, I've tried a couple different ways, there's just enough different with the APIs between coc & vscode that I don't think there's a way to proxy them effectively. With that in mind, I think I'm going to decline this and say if you want this to run on coc/neovim, then fork it and have it a separate plugin. I don't make that many changes to it over time, keeping up to date shouldn't be hard. But I don't want mixing the coc environment with the vscode environment stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants