Skip to content

Bugfix XRPToDrops Conversion fixes #89 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JakeLardinois wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bugfix XRPToDrops Conversion fixes #89 #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 13 additions & 24 deletions Xrpl/Utils/XrpConversion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,41 +155,30 @@ public static string XrpToDrops(double xrpToConvert)
/// <returns>Amount in drops.</returns>
public static string XrpToDrops(string xrpToConvert)
{
// Important: specify base BASE_TEN to avoid exponential notation, e.g. '1e-7'.
// TODO: SHOULD BE BASE 10
string xrp = decimal.Parse(xrpToConvert, NumberStyles.AllowLeadingSign
| (NumberStyles.AllowLeadingSign & NumberStyles.AllowDecimalPoint)
| (NumberStyles.AllowLeadingSign & NumberStyles.AllowExponent)
| (NumberStyles.AllowLeadingSign & NumberStyles.AllowExponent & NumberStyles.AllowDecimalPoint)
| (NumberStyles.AllowExponent & NumberStyles.AllowDecimalPoint)
| NumberStyles.AllowExponent
| NumberStyles.AllowDecimalPoint, CultureInfo.InvariantCulture).ToString();
// check that the value is valid and actually a number
if (!(xrpToConvert is string) && xrp != null)
{
throw new ValidationException($"xrpToConvert: invalid value '{xrpToConvert}', should be a BigInteger or string - encoded number.");
}
// Parse with base 10; supports signs, decimals, and scientific notation.
decimal xrpValue = decimal.Parse(xrpToConvert, NumberStyles.Float, CultureInfo.InvariantCulture);

// drops are only whole units
// Round to 6 decimal places as required by XRP spec
xrpValue = Math.Round(xrpValue, MAX_FRACTION_LENGTH, MidpointRounding.AwayFromZero);

// Convert to string to inspect decimal structure
string xrp = xrpValue.ToString(CultureInfo.InvariantCulture);

// Validate structure
string[] components = xrp.TrimEnd('0').Split('.');
if (components.Length > 2)
{
throw new ValidationException("xrpToDrops: failed sanity check - value '${xrp}' has too many decimal points.");
throw new ValidationException($"xrpToDrops: failed sanity check - value '{xrp}' has too many decimal points.");
}

string fraction = components.Length > 1 && components[1] != null ? components[1] : "0";
if (fraction.Length > MAX_FRACTION_LENGTH)
{
throw new ValidationException($"xrpToDrops: value '{xrp}' has too many decimal places.");
}
// TODO: SHOULD BE BASE 10
return new BigInteger(decimal.Parse(xrpToConvert, NumberStyles.AllowLeadingSign
| (NumberStyles.AllowLeadingSign & NumberStyles.AllowDecimalPoint)
| (NumberStyles.AllowLeadingSign & NumberStyles.AllowExponent)
| (NumberStyles.AllowLeadingSign & NumberStyles.AllowExponent & NumberStyles.AllowDecimalPoint)
| (NumberStyles.AllowExponent & NumberStyles.AllowDecimalPoint)
| NumberStyles.AllowExponent
| NumberStyles.AllowDecimalPoint, CultureInfo.InvariantCulture) * (decimal)new BigInteger(DROPS_PER_XRP)).ToString();

// Convert XRP to drops, avoiding casts or changing DROPS_PER_XRP
return new BigInteger(xrpValue * (decimal)new BigInteger(DROPS_PER_XRP)).ToString(CultureInfo.InvariantCulture);
}
}
}