Make FactoredMatrix compatible with tensor-like arguments #599
Draft
JasonGross wants to merge 2 commits intoTransformerLensOrg:devfrom
Draft
Make FactoredMatrix compatible with tensor-like arguments #599JasonGross wants to merge 2 commits intoTransformerLensOrg:devfrom
FactoredMatrix compatible with tensor-like arguments #599JasonGross wants to merge 2 commits intoTransformerLensOrg:devfrom
Conversation
I'd like to be able to use `FactoredMatrix` with things that implement the interface of `torch.Tensor` without subclassing it. This slight change allows `FactoredMatrix` to work with such classes rather than returning `None` in various places.
Collaborator
|
@JasonGross Do you still have a bit to wrap up on this? If you need any help getting this out the door let me know. If you could add a test for this, that would be greatly appreciated as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'd like to be able to use
FactoredMatrixwith things that implement the interface oftorch.Tensorwithout subclassing it. This slight change allowsFactoredMatrixto work with such classes rather than returningNonein various places.(I haven't finished the checklists, so creating this draft PR so I don't forget about this)
Type of change
Please delete options that are not relevant.
Checklist: