Skip to content

Fix blockchain fee calculation. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PurpleTheBest merged 1 commit into from
Nov 24, 2025
Merged

Fix blockchain fee calculation. #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions csharp/src/Common/Common.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Nethereum.Web3" Version="4.29.0" />
<PackageReference Include="Temporalio.Extensions.Hosting" Version="1.5.0" />
<PackageReference Include="Microsoft.AspNetCore.Http.Abstractions" Version="2.3.0" />
<PackageReference Include="Nethereum.Util" Version="4.29.0" />
Expand Down
17 changes: 17 additions & 0 deletions csharp/src/Common/Extensions/Web3ClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
using Nethereum.Hex.HexTypes;
using Nethereum.Web3;
using System.Numerics;

namespace Train.Solver.Common.Extensions;

public static class Web3ClientExtensions
{
public static async Task<BigInteger> GetMaxPriorityFeePerGasAsync(this IWeb3 web3)
{
var request = new Nethereum.JsonRpc.Client.RpcRequest(Guid.NewGuid().ToString(), "eth_maxPriorityFeePerGas");

var response = await web3.Client.SendRequestAsync<string>(request);

return new HexBigInteger(response);
}
}
9 changes: 5 additions & 4 deletions csharp/src/Workflow.EVM/Helpers/EthereumEIP1559FeeEstimator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ public class EthereumEIP1559FeeEstimator(ISmartNodeInvoker smartNodeInvoker) : F

public virtual int HighPriorityBlockCount => 5;

private const string MinMaxPriorityFeePerGas = "1";

public override BigInteger CalculateFee(Block block, Transaction transaction, EVMTransactionReceipt receipt)
{
return receipt.GasUsed * (block.BaseFeePerGas + transaction.MaxPriorityFeePerGas.Value);
Expand Down Expand Up @@ -66,15 +68,14 @@ async Task<Fee> GetFeeAmountAsync(
suggestedFees.BaseFee.Value.CompoundInterestRate(MaximumBaseFeeIncreasePerBlock, blockCount);

// Node returns 0 but transfer service throws exception in case of 0
suggestedFees.MaxPriorityFeePerGas += 1;
suggestedFees.MaxPriorityFeePerGas =
suggestedFees.MaxPriorityFeePerGas.Value.PercentageIncrease(feePercentageIncrease);
var maxPriorityFeePerGas = BigInteger.Parse(MinMaxPriorityFeePerGas);
maxPriorityFeePerGas += (await web3.GetMaxPriorityFeePerGasAsync()).PercentageIncrease(feePercentageIncrease);

return new Fee(
feeCurrency.Symbol,
feeCurrency.Decimals,
new EIP1559Data(
suggestedFees.MaxPriorityFeePerGas.Value,
maxPriorityFeePerGas,
increasedBaseFee,
gasLimit));
}
Expand Down
2 changes: 1 addition & 1 deletion csharp/src/Workflow.Solana/Workflow.Solana.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Nethereum.Web3Lite" Version="4.29.0" />
<PackageReference Include="Nethereum.Web3" Version="4.29.0" />
<PackageReference Include="Solnet.Extensions" Version="6.1.0" />
<PackageReference Include="Flurl.Http" Version="4.0.2" />
</ItemGroup>
Expand Down