Replace java2html with JHighlight#382
Draft
NirBY wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the legacy
java2html.jarsource-code HTML rendering path with the maintained Maven dependencyorg.codelibs:jhighlight:1.1.1.What changed:
org.codelibs:jhighlight:1.1.1to parent dependency management.jsystemCoredependency soHtmlCodeWritercan render source directly.thirdparty/commonLib/jhighlight.jar.thirdparty/commonLib/jhighlight.jarinstead ofthirdparty/lib/java2html.jar.de.java2html.*parser/converter calls inHtmlCodeWriterwithJavaXhtmlRenderer.java2html.jar.HtmlCodeWriterTestto verify Java source is rendered through JHighlight.Compatibility notes
JHighlight 1.1.1was selected intentionally because it is Java 8 bytecode compatible (major version: 52) and therefore remains compatible with both currentmasterand the Java 11 migration path.JHighlight 2.0.0was checked but not used because it targets Java 17, which would skip over the requested Java 11 compatibility step.Verification
Passed:
mvn -f jsystem-core-projects\pom.xml -pl jsystemCore -am -DskipTests packageusing JDK 8mvn -f jsystem-core-projects\pom.xml -pl jsystemCore "-Dtest=jsystem.extensions.report.html.HtmlCodeWriterTest" testusing JDK 8mvn -f jsystem-core-projects\pom.xml -pl jsystemCore "-Dincludes=org.codelibs:jhighlight" dependency:treeconfirmedorg.codelibs:jhighlight:jar:1.1.1:compilegit diff --cached --checkgit grep -n -i "java2html\|de\.java2html" -- . ':!*.jar' ':!*.class'found no remaining source referencesKnown current-master/environment test noise:
mvn -f jsystem-core-projects\pom.xml -pl jsystemCore -am testrun compiled successfully and the newHtmlCodeWriterTestpassed, but the broader legacy suite failed on existing environment-dependent tests: missing generatedMETA-INF/jsystemCore.build.properties, missingreport8.html, and no local POP3 server forPublishTest.Upgrade plan
master.1.1.1until the project intentionally moves beyond Java 11, because newer JHighlight currently requires Java 17.