Skip to content

src: fix localtime in case NaN is passed #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santigimeno wants to merge 1 commit into
base: master
Choose a base branch
from
Open

src: fix localtime in case NaN is passed #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,19 @@ exports.currentTimezone = process.env.TZ;
*/

exports.time = bindings.time;
exports.localtime = bindings.localtime;
exports.mktime = bindings.mktime;

/**
* Check if the first argument is NaN and just return in case it is.
*/
exports.localtime = function localtime() {
if ((arguments[0] !== undefined) && isNaN(arguments[0])) {
return { invalid: true };
} else {
return bindings.localtime.apply(null, arguments);
}
};

/**
* A "hack" of sorts to force getting our own Date instance.
* Otherwise, in normal cases, the global Natives are shared between
Expand Down