Skip to content

Fixes #112 deprecated V8 API usage (also updates documentation from using var to const) #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
riyadshauk wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes #112 deprecated V8 API usage (also updates documentation from using var to const) #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32616e0
update unsupported v8 API usage, should fix #112
riyadshauk Sep 6, 2019
e678c2f
update unsupported V8::Handle --> V8::Local
riyadshauk Sep 6, 2019
b77fe20
use const;
riyadshauk Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 38 additions & 38 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ Example
-------

``` javascript
var time = require('time');
const time = require('time');

// Create a new Date instance, representing the current instant in time
var now = new time.Date();
const now = new time.Date();

now.setTimezone("America/Los_Angeles");
// `.getDate()`, `.getDay()`, `.getHours()`, etc.
Expand All @@ -39,7 +39,7 @@ now.setTimezone("America/New_York");


// You can also set the timezone during instantiation
var azDate = new time.Date(2010, 0, 1, 'America/Phoenix');
const azDate = new time.Date(2010, 0, 1, 'America/Phoenix');
azDate.getTimezone(); // 'America/Phoenix'
```

Expand All @@ -52,9 +52,9 @@ instances. To extend the global Date object, simply pass it in as an argument to
the node-time module when requiring:

``` js
var time = require('time')(Date);
const time = require('time')(Date);

var d = new Date();
const d = new Date();
d.setTimezone('UTC');
```

Expand All @@ -74,9 +74,9 @@ magic _timezone_ capabilities! You can also pass a `timezone` as the last
argument in order to have a Date instance in the specified timezone.

``` javascript
var now = new time.Date();
var another = new time.Date('Aug 9, 1995', 'UTC');
var more = new time.Date(1970, 0, 1, 'Europe/Amsterdam');
const now = new time.Date();
const another = new time.Date('Aug 9, 1995', 'UTC');
const more = new time.Date(1970, 0, 1, 'Europe/Amsterdam');
```


Expand All @@ -93,19 +93,19 @@ instead the internal state of the Date instance is changed, such that the local
date.setTimezone("America/Argentina/San_Juan")

// Default behavior:
a = new time.Date()
a.toString()
const a = new time.Date();
a.toString();
// 'Wed Aug 31 2011 09:45:31 GMT-0700 (PDT)'
a.setTimezone('UTC')
a.toString()
a.setTimezone('UTC');
a.toString();
// 'Wed Aug 31 2011 16:45:31 GMT+0000 (UTC)'

// Relative behavior:
b = new time.Date()
b.toString()
const b = new time.Date();
b.toString();
// 'Wed Aug 31 2011 10:48:03 GMT-0700 (PDT)'
b.setTimezone('UTC', true)
b.toString()
b.setTimezone('UTC', true);
b.toString();
// 'Wed Aug 31 2011 10:48:03 GMT+0000 (UTC)'
```

Expand All @@ -117,7 +117,7 @@ This must be called _after_ `setTimezone()` has been called.

``` javascript
date.getTimezone();
// "America/Argentina/San_Juan"
// "America/Argentina/San_Juan"
```


Expand All @@ -128,7 +128,7 @@ Useful for the presentation layer of a Date instance.

``` javascript
date.getTimezoneAbbr();
// "ART"
// "ART"
```


Expand All @@ -141,11 +141,11 @@ aliased as `time.parse()`.

``` javascript
time.Date.parse("1970, January 1"); // <- Local Time
// 28800000
// 28800000
time.Date.parse("1970, January 1", "Europe/Copenhagen");
// -3600000
// -3600000
time.Date.parse("1970, January 1", "UTC");
// 0
// 0
```


Expand All @@ -154,7 +154,7 @@ time.Date.parse("1970, January 1", "UTC");
Transforms a "regular" Date instance into one of `node-time`'s "extended" Date instances.

``` javascript
var d = new Date();
const d = new Date();
// `d.setTimezone()` does not exist...
time.extend(d);
d.setTimezone("UTC");
Expand All @@ -168,9 +168,9 @@ These two are equivalent:

``` javascript
time.time();
// 1299827226
// 1299827226
Math.floor(Date.now() / 1000);
// 1299827226
// 1299827226
```


Expand All @@ -184,9 +184,9 @@ for the specified timezone.

``` javascript
time.tzset('US/Pacific');
// { tzname: [ 'PST', 'PDT' ],
// timezone: 28800,
// daylight: 1 }
// { tzname: [ 'PST', 'PDT' ],
// timezone: 28800,
// daylight: 1 }
```


Expand All @@ -199,17 +199,17 @@ representation of the timestamp, according the the currently configured timezone

``` javascript
time.localtime(Date.now()/1000);
// { seconds: 38,
// minutes: 7,
// hours: 23,
// dayOfMonth: 10,
// month: 2,
// year: 111,
// dayOfWeek: 4,
// dayOfYear: 68,
// isDaylightSavings: false,
// gmtOffset: -28800,
// timezone: 'PST' }
// { seconds: 38,
// minutes: 7,
// hours: 23,
// dayOfMonth: 10,
// month: 2,
// year: 111,
// dayOfWeek: 4,
// dayOfYear: 68,
// isDaylightSavings: false,
// gmtOffset: -28800,
// timezone: 'PST' }
```


Expand Down
20 changes: 10 additions & 10 deletions src/time.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ using namespace v8;

class Time {
public:
static void Init(Handle<Object> target) {
static void Init(Local<Object> target) {
Nan::HandleScope scope;

// time(3)
Expand Down Expand Up @@ -84,7 +84,7 @@ class Time {
Nan::EscapableHandleScope scope;

// Construct the 'tm' struct
time_t rawtime = static_cast<time_t>(info[0]->IntegerValue());
time_t rawtime = static_cast<time_t>(info[0]->IntegerValue(Nan::GetCurrentContext()).FromJust());
struct tm *timeinfo = localtime( &rawtime );

// Create the return "Object"
Expand Down Expand Up @@ -138,13 +138,13 @@ class Time {
Local<Object> arg = info[0].As<v8::Object>();

struct tm tmstr;
tmstr.tm_sec = Nan::Get(arg, Nan::New("seconds").ToLocalChecked()).ToLocalChecked()->Int32Value();
tmstr.tm_min = Nan::Get(arg, Nan::New("minutes").ToLocalChecked()).ToLocalChecked()->Int32Value();
tmstr.tm_hour = Nan::Get(arg, Nan::New("hours").ToLocalChecked()).ToLocalChecked()->Int32Value();
tmstr.tm_mday = Nan::Get(arg, Nan::New("dayOfMonth").ToLocalChecked()).ToLocalChecked()->Int32Value();
tmstr.tm_mon = Nan::Get(arg, Nan::New("month").ToLocalChecked()).ToLocalChecked()->Int32Value();
tmstr.tm_year = Nan::Get(arg, Nan::New("year").ToLocalChecked()).ToLocalChecked()->Int32Value();
tmstr.tm_isdst = Nan::Get(arg, Nan::New("isDaylightSavings").ToLocalChecked()).ToLocalChecked()->Int32Value();
tmstr.tm_sec = Nan::Get(arg, Nan::New("seconds").ToLocalChecked()).ToLocalChecked()->Int32Value(Nan::GetCurrentContext()).FromJust();
tmstr.tm_min = Nan::Get(arg, Nan::New("minutes").ToLocalChecked()).ToLocalChecked()->Int32Value(Nan::GetCurrentContext()).FromJust();
tmstr.tm_hour = Nan::Get(arg, Nan::New("hours").ToLocalChecked()).ToLocalChecked()->Int32Value(Nan::GetCurrentContext()).FromJust();
tmstr.tm_mday = Nan::Get(arg, Nan::New("dayOfMonth").ToLocalChecked()).ToLocalChecked()->Int32Value(Nan::GetCurrentContext()).FromJust();
tmstr.tm_mon = Nan::Get(arg, Nan::New("month").ToLocalChecked()).ToLocalChecked()->Int32Value(Nan::GetCurrentContext()).FromJust();
tmstr.tm_year = Nan::Get(arg, Nan::New("year").ToLocalChecked()).ToLocalChecked()->Int32Value(Nan::GetCurrentContext()).FromJust();
tmstr.tm_isdst = Nan::Get(arg, Nan::New("isDaylightSavings").ToLocalChecked()).ToLocalChecked()->Int32Value(Nan::GetCurrentContext()).FromJust();
// tm_wday and tm_yday are ignored for input, but properly set after 'mktime' is called

info.GetReturnValue().Set(scope.Escape(Nan::New<v8::Number>(static_cast<double>(mktime( &tmstr )))));
Expand All @@ -153,7 +153,7 @@ class Time {
};

extern "C" {
static void init (Handle<Object> target) {
static void init (Local<Object> target) {
Time::Init(target);
}
NODE_MODULE(time, init)
Expand Down