fix: Don't error when passing too new warning flags to old clang.#270
Merged
toktok-releaser merged 1 commit intoTokTok:masterfrom Feb 10, 2026
Merged
fix: Don't error when passing too new warning flags to old clang.#270toktok-releaser merged 1 commit intoTokTok:masterfrom
toktok-releaser merged 1 commit intoTokTok:masterfrom
Conversation
Older macOS versions with older xcode versions with older clang versions don't have these warning flags. On newer ones, we do need those suppressions. Alternative would be to detect support, but in this case, we don't really care to be extremely clean.
github-actions
bot
added
the
bug
robinlinden
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older macOS versions with older xcode versions with older clang versions don't have these warning flags. On newer ones, we do need those suppressions. Alternative would be to detect support, but in this case, we don't really care to be extremely clean.
This change is