Skip to content

fix: Fix the libqrencode build under MacOS 10.15#200

Merged
Green-Sky merged 1 commit into
TokTok:masterfrom
nickolay168:nickolay168/fix_mac_build
May 7, 2026
Merged

fix: Fix the libqrencode build under MacOS 10.15#200
Green-Sky merged 1 commit into
TokTok:masterfrom
nickolay168:nickolay168/fix_mac_build

Conversation

@nickolay168
Copy link
Copy Markdown
Contributor

@nickolay168 nickolay168 commented Mar 30, 2026

In MacOS 10.15 I have stareted seeing the CI failures as follows:

cmake . -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/Users/runner/work/deps -DCMAKE_OSX_DEPLOYMENT_TARGET=10.15 -DCMAKE_OSX_DEPLOYMENT_TARGET=10.15 -DWITH_TOOLS=OFF -DBUILD_SHARED_LIBS=OFF
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

It is caused by this line in the libqrencode CmakeLists.txt. I have added -DCMAKE_POLICY_VERSION_MINIMUM=3.5 flag to redefine the minimal Cmake version.


This change is Reviewable

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

Tip

Preview URL:

@github-actions github-actions Bot added the bug Bug fix for the user, not a fix to a build script label Mar 30, 2026
@nickolay168 nickolay168 force-pushed the nickolay168/fix_mac_build branch from 79f5cc5 to 6e06038 Compare April 4, 2026 07:20
@nickolay168
Copy link
Copy Markdown
Contributor Author

Hi, @iphydf, In this PR I have updated the Bazel version to fix the build, but circleci uses script from the master branch and I cannot test my changes. Would it be possible to run test from my branch to see if Bazel upgrade fixes the issue?

@Green-Sky
Copy link
Copy Markdown
Member

Hi, @iphydf, In this PR I have updated the Bazel version to fix the build, but circleci uses script from the master branch and I cannot test my changes. Would it be possible to run test from my branch to see if Bazel upgrade fixes the issue?

I extracted that change to #201 . Let's see if that fixes the issue.

@Green-Sky
Copy link
Copy Markdown
Member

@nickolay168 If you remove the bazel change we can merge this as a workaround.

@Green-Sky Green-Sky added this to the v0.8.5 milestone May 5, 2026
@nickolay168 nickolay168 force-pushed the nickolay168/fix_mac_build branch from 6e06038 to 580fc59 Compare May 6, 2026 03:19
@nickolay168 nickolay168 marked this pull request as ready for review May 6, 2026 03:27
@nickolay168
Copy link
Copy Markdown
Contributor Author

@nickolay168 If you remove the bazel change we can merge this as a workaround.

Fixed! Thank you!

@Green-Sky Green-Sky merged commit 580fc59 into TokTok:master May 7, 2026
26 of 28 checks passed
@Green-Sky
Copy link
Copy Markdown
Member

Didn't fix it. Hm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bug fix for the user, not a fix to a build script

Development

Successfully merging this pull request may close these issues.

2 participants