Skip to content

Fix Viewer Engine incorrectly evaluating rules #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tofaa2 merged 1 commit into from
May 22, 2026
Merged

Fix Viewer Engine incorrectly evaluating rules #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions api/src/main/java/me/tofaa/entitylib/ve/ViewerEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,19 @@ public void clearTracked() {
* @return true if the user passed and did not fail any rules, false otherwise
*/
public boolean canSpawnFor(User user, WrapperEntity entity) {
if (!entity.getViewerRules().isEmpty() && entity.getViewerRules().stream().allMatch(rule -> rule.shouldSee(user))) return true;
return globalRules.stream().allMatch(rule -> rule.shouldSee(user));
for (ViewerRule rule : entity.getViewerRules()) {
if (!rule.shouldSee(user)) {
return false;
}
}

for (ViewerRule rule : this.globalRules) {
if (!rule.shouldSee(user)) {
return false;
}
}

return true;
}

/**
Expand Down
Loading