Change behavior for ReaderFlags.BIGNUM_AS_RAW and ReaderFlags.NUMBERS_AS_RAW#16
Open
MichaelSquires wants to merge 1 commit intoTkTech:mainfrom
Open
Change behavior for ReaderFlags.BIGNUM_AS_RAW and ReaderFlags.NUMBERS_AS_RAW#16MichaelSquires wants to merge 1 commit intoTkTech:mainfrom
MichaelSquires wants to merge 1 commit intoTkTech:mainfrom
Conversation
Author
|
Hi, I realize this is a potentially controversial change and I'm glad to discuss it. Basically, we needed to be able to deserialize large integers without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
ReaderFlags.BIGNUM_AS_RAW:2**64, <-2**63) asDecimals.2**64, <-2**63) as python long integers.ReaderFlags.NUMBERS_AS_RAW:Decimals.Note: These changes are not backward compatible and will probably require a major version bump.