Fix plug-ins with parameters #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I enabled `ADMINER_PLUGINS=login-servers` and created `plugins-enabled/login-servers.php` as instructed in the plugin-loader error message, it would still try to create its own file in plugins-enabled, and then continue to complain, not noticing the file I added. Let’s skip creating the file when a manually created one exists.
|
@TimWolla Can this be merged? It is currently impossible to use a plugin with parameters right now because the expected file always gets overwritten at start up (even if it already exists), then the container will exit since the file is empty. It appears this change adds a file exists check before attempting to create a new configuration file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I enabled
ADMINER_PLUGINS=login-serversand createdplugins-enabled/login-servers.phpas instructed in the plugin-loader error message, it would still try to create its own file in plugins-enabled, and then continue to complain, not noticing the file I added.Let’s skip creating the file when a manually created one exists.