Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions design-system/pkg/src/toast/test/Toast.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,11 @@ describe('toast/Toast', () => {

await user.click(button);
fireAnimationEnd(toast);

// TODO: This test fails when running `pnpm test-strict` which enables React Strict Mode
// and renders components twice.
// Why? Most likely because ToastToggle component is not pure.
// The double rendering seem to get its internal state out of sync.
expect(queryByRole('alert')).toBeNull();
});

Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"start:designsystem": "pnpm --filter=@keystar/docs start",
"static": "pnpm run validate && pnpm run test",
"test": "pnpm run test:unit",
"test-strict": "cross-env STRICT_MODE=1 pnpm run test",
"test-strict": "STRICT_MODE=1 pnpm run test",
"test:coverage": "jest ---coverage",
"test:unit": "NODE_OPTIONS=--experimental-vm-modules jest",
"validate": "pnpm run '/check:*/'",
Expand All @@ -60,7 +60,6 @@
"@typescript-eslint/eslint-plugin": "^5.29.0",
"@typescript-eslint/parser": "^5.29.0",
"babel-plugin-react-compiler": "^0.0.0-experimental-696af53-20240625",
"cross-env": "^7.0.3",
"eslint": "^8.18.0",
"eslint-config-next": "^12.1.6",
"eslint-config-prettier": "^8.5.0",
Expand Down
12 changes: 0 additions & 12 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ packages:
- 'keystatic'
- 'packages/*'
- 'templates/*'

# Ensure environment variables defined via NPM scripts work consistently for all operating systems.
shellEmulator: true