fix(agent): preserve failed context#1608
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR preserves failed message context to help agents recover from errors. It introduces an eligibility predicate to classify context-eligible records (sent user messages and assistant error messages), formats error reasons into readable summaries, integrates these summaries into chat message conversion and compaction logic, and updates history selection across context building, compaction, and runtime components. ChangesFailed Message Context Preservation
Sequence Diagram(s)sequenceDiagram
participant User
participant DB as MessageStore
participant Presenter as recordToChatMessages
participant Formatter as formatAssistantErrorSummary
participant Compactor as prepareCompaction
User->>DB: prior assistant/error records persisted
DB->>Presenter: fetch candidate records (isContextHistoryRecord)
Presenter->>Formatter: extract & format error reasons
Formatter-->>Presenter: formatted summary
Presenter->>Compactor: pass history (with appended error summaries)
Compactor-->>Presenter: compaction result / serialized assistant text
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/main/presenter/agentRuntimePresenter/compactionService.ts`:
- Around line 184-187: serializeAssistantRecord currently only pushes a failure
summary when formatAssistantErrorSummary(errorMessages) returns a value, causing
compaction to omit failure context for records where record.status === 'error'
but no explicit error blocks exist; update serializeAssistantRecord so that
after computing errorSummary from formatAssistantErrorSummary(errorMessages) you
check if record.status === 'error' and errorSummary is falsy, then push the same
"unknown failure" fallback used by recordToChatMessages (or construct an
equivalent assistant:error summary) into lines to keep compaction output in sync
with runtime context.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 69fd93b1-d486-403c-b166-40a0fafd6dc4
📒 Files selected for processing (8)
docs/issues/failed-message-context/plan.mddocs/issues/failed-message-context/spec.mddocs/issues/failed-message-context/tasks.mdsrc/main/presenter/agentRuntimePresenter/compactionService.tssrc/main/presenter/agentRuntimePresenter/contextBuilder.tssrc/main/presenter/agentRuntimePresenter/index.tstest/main/presenter/agentRuntimePresenter/compactionService.test.tstest/main/presenter/agentRuntimePresenter/contextBuilder.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Summary by CodeRabbit
New Features
Documentation
Tests