더 나은 프로그래머 되는법 2주차 - 이동현 #539
Conversation
dhlee3994
requested review from
TaeHyoungKwon,
aquamagic9,
fkdl0048,
hemil0102,
jongfeel,
tttghost and
ymkim97
|
우측에 있는 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @dhlee3994, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request by dhlee3994 adds a markdown file summarizing chapters 9-13 of 'Becoming a Better Programmer'. The summary includes key points and discussion prompts related to writing good code, testing, code structure, and managing dependencies. The PR also closes issue #534, presumably related to this content contribution.
Highlights
- Content Summary: The pull request introduces a summary of chapters 9-13 from 'Becoming a Better Programmer', focusing on key concepts for writing better code.
- Discussion Points: The summary includes discussion prompts related to practical experiences in improving code quality and design.
- Key Takeaways: The summary highlights important principles such as the importance of testing, modular code structure, and managing dependencies to improve code maintainability.
Changelog
- 2025/Becoming a Better Programmer/donghyeon/ch9~13.md
- Added a new markdown file summarizing chapters 9-13 of 'Becoming a Better Programmer'.
- Included discussion prompts related to improving code quality.
- Highlighted key concepts such as the importance of testing and modular code structure.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A leaky cup, a coder's plight,
Tests as bleach, shining bright.
Modules small and neat,
A structure complete,
Dependencies managed just right.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request adds a summary of chapters 9-13 from the book 'Becoming a Better Programmer'. The content focuses on writing good code, testing, modularity, and managing dependencies. The summary provides key takeaways from each chapter, which can be helpful for reinforcing the book's concepts. Overall, the changes are well-structured and easy to understand.
Merge Readiness
The pull request is ready to be merged. The changes are well-structured and easy to understand. There are no critical or high severity issues. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
|
|
||
| ## 논의 | ||
|
|
||
| - 지저분한 대도시에서 디자인 타운으로 변경한 경험이 있다면 공유하면 좋을 것 같습니다. 이러한 경험이 없다면 디자인 타운을 만들기 위해 개인적으로 하는 노력을 공유하면 좋을 것 같습니다. |
There was a problem hiding this comment.
중요한 코어 도메인의 비즈니스 로직의 경우는 디자인 타운에서 말하는 것들을 가능한 지키려고 노력하고 있습니다
사실상 모든 코드 베이스가 디자인 타운과 같이 유지한다는 것은 그 유지비용도 비용이기 때문에, 유지를 하더라도 비용이 많이 들것이라 생각하고 현실적으로는 중요한 것을 선별해서 적용하는것이 맞다고 생각합니다
|
|
||
| ## 논의 | ||
|
|
||
| - 지저분한 대도시에서 디자인 타운으로 변경한 경험이 있다면 공유하면 좋을 것 같습니다. 이러한 경험이 없다면 디자인 타운을 만들기 위해 개인적으로 하는 노력을 공유하면 좋을 것 같습니다. |
There was a problem hiding this comment.
지저분한 대도시가 되는 방향으로 가고 있다면 디자인 타운으로 바꾸기 위한 시간을 들여서 조금씩 변경을 하고 있습니다.
조금씩 리뷰하고 조금씩 수정하고 하는 원칙을 가지고 실천하고 있어요.
github-project-automation
bot
moved this from In review
to Done
in 2025 Academic Conference
요일을 착각 했네요. 죄송합니다.
close #534