Skip to content

Deploy #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madcowfred merged 7 commits into from
Apr 28, 2026
Merged

Deploy #1749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
de57e6e
Transmog set items count as collected if there's any overlap between …
Apr 27, 2026
989e85e
Use CharacterAddonData for paragons instead of CharacterReputations
Apr 28, 2026
7724b4a
Fix account reputations applying in reverse order, should be oldest t…
Apr 28, 2026
8bf6f0b
Change short name for children's week
Apr 28, 2026
32b09ba
Fix achievement have state for criteria trees
Apr 28, 2026
4c5655e
Fix transmog set collected count when completionist mode is off
Apr 28, 2026
0b7ddcd
Fix auctions result row for items
Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/frontend/auctions/components/results/ResultsRow.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@

ret.icon = `item/${itemId}`;
ret.itemLevel = parseInt(parts[2]) || item?.itemLevel || 1;
ret.name = `{${groupKey}}`;
ret.name = `{item:${itemId}}`;
} else if (groupKey.startsWith('pet:')) {
const pet = wowthingData.static.petById.get(parseInt(groupKey.split(':')[1]));
ret.icon = `npc/${pet.creatureId}`;
Expand Down
3 changes: 2 additions & 1 deletion apps/frontend/components/achievements/CriteriaTree.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,9 @@
linkType = 'achievement';
linkId = criteria.asset;

const earned = userState.achievements.achievementEarnedById.has(criteria.asset);
const earned = userState.achievements.achievementEarnedById.get(criteria.asset);
if (earned) {
have = true;
linkParams['who'] = 'You';
linkParams['when'] = earned.toString() + '000';
}
Expand Down
2 changes: 1 addition & 1 deletion apps/frontend/data/holidays.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const fancyHolidays: FancyHoliday[] = [
},
{
holiday: Holiday.ChildrensWeek,
shortName: 'Children',
shortName: '👶',
everything: 'childrens-week',
},
{
Expand Down
14 changes: 10 additions & 4 deletions apps/frontend/user-home/state/lazy/transmog.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,17 @@ export function doTransmog(): LazyTransmog {

const hasSource = overrideHas || hasAppearanceBySource.has(itemId * 1000 + modifier);
const hasAppearance = hasSource || overrideHas || hasAppearanceById.has(appearanceId);
const hasCompletionist = completionistMode ? hasSource : hasAppearance;

slotData[actualSlot] ||= [false, []];
slotData[actualSlot][0] ||= completionistMode ? hasSource : hasAppearance;
slotData[actualSlot][1].push([hasAppearance, hasSource, itemId, modifier, appearanceId]);
slotData[actualSlot][0] ||= hasCompletionist;
slotData[actualSlot][1].push([
hasAppearance,
hasCompletionist,
itemId,
modifier,
appearanceId,
]);
};

const completionistMode = settingsState.value.transmog.completionistMode;
Expand Down Expand Up @@ -218,8 +225,7 @@ export function doTransmog(): LazyTransmog {
if (
item.classMask > 0 &&
transmogSet.classMask > 0 &&
(item.classMask & transmogSet.classMask) !==
transmogSet.classMask
(item.classMask & transmogSet.classMask) === 0
) {
continue;
}
Expand Down
5 changes: 4 additions & 1 deletion apps/web/Controllers/ApiController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,10 @@ await _cacheService.CreateOrUpdateTransmogCacheAsync(

// Reputations
var reputations = new Dictionary<int, int>();
foreach (var account in accounts.Where(account => account.AddonData?.Reputations != null).OrderByDescending(account => account.AddonData.ReputationsScannedAt))
var repAccounts = accounts
.Where(account => account.AddonData?.Reputations != null)
.OrderBy(account => account.AddonData.ReputationsScannedAt);
foreach (var account in repAccounts)
{
foreach ((int factionId, int value) in account.AddonData.Reputations)
{
Expand Down
4 changes: 2 additions & 2 deletions apps/web/Models/Api/User/ApiUserCharacter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public class ApiUserCharacter
public ApiUserCharacterMythicPlus MythicPlus { get; }
public Dictionary<int, ApiUserCharacterAddonDataMythicPlus> MythicPlusAddon { get; }
public Dictionary<int, Dictionary<int, PlayerCharacterAddonDataMythicPlusMap>> MythicPlusSeasons { get; set; }
public Dictionary<int, PlayerCharacterReputationsParagon> Paragons { get; }
public Dictionary<int, PlayerCharacterAddonDataParagon> Paragons { get; }
public Dictionary<int, List<PlayerCharacterAddonDataPatronOrder>> PatronOrders { get; set; }
public Dictionary<int, Dictionary<int, PlayerCharacterProfessionTier>> Professions { get; }
public Dictionary<string, List<int>> ProfessionCooldowns { get; set; }
Expand Down Expand Up @@ -157,7 +157,7 @@ public ApiUserCharacter(
RawSpecializations = character.Specializations?.Specializations;

Configuration = new ApiUserCharacterConfiguration(character.Configuration);
Paragons = character.Reputations?.Paragons ?? new Dictionary<int, PlayerCharacterReputationsParagon>();
Paragons = character.AddonData?.Paragons ?? new Dictionary<int, PlayerCharacterAddonDataParagon>();

RawItems = items;
// Bags = bagItems
Expand Down
Loading