Improve gateway error messages#7905
Draft
mjamescompton wants to merge 1 commit intov3.36from
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend the error mapping for claim related errors regarding The Things Indoor Gateway Pro.
Changes
getClaimGatewayErrorMessageTesting
Steps
To test this you need to setup The Things Indoor Gateway Pro to a selection of states. This can only be done internally by the team.
Configure the The Things Indoor Gateway Pro billing to be suspended, detached, not set. Use the gateway owner token.
Error messages
Configure the The Things Indoor Gateway Pro billing to be not set. Create a fleet with no slots. Use the gateway owner token to register gateway.
Error message
Configure the The Things Indoor Gateway Pro to be attached to a Gateway License within a fleet, create a second Gateway Fleet and use the empty fleets owner token.
Error message
Go to register gateway in the console. Using the provided gateway EUIs and owner token for each state and check to see the correct error messages.
Results
Regressions
Before updates to the Gateway Controller the raw error messages from the stack will be shown.
Notes for Reviewers
...
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.