Conversation
johanstokking
approved these changes
Feb 18, 2026
halimi
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
go fix ./...to modernize the codebase.https://go.dev/blog/gofix
Changes
forloops withslices.Contains,slices.SortFunc,slices.Clone, etc.maps.Copyandmaps.Clonereflect.TypeOf((*T)(nil)).Elem()withreflect.TypeFor[T]()reflect.Ptrwithreflect.Pointerfor i := 0; i < n; i++withfor i := range n(integer range loops)omitemptyon struct-typed JSON fieldsTesting
Steps
Run
go build ./...andgo test ./...to verify no regressions.Results
The changes are all mechanical transformations applied by
go fix.Regressions
omitemptyremoval on struct-typed JSON fields is behavior-preserving:omitemptywas already a no-op for struct types inencoding/json.slices,maps,reflect.TypeFor,reflect.Pointer, integer range) are semantically equivalent to the replaced code.Notes for Reviewers
All changes were generated by
go fix ./.... No manual edits.Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.