Chore: Rework to avoid raw pointers #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use instances instead of pointers. Where pointers are needed, the address of these objects can be given. This removes a small amount of resource handling code in quit().
Use instances instead of pointers. Where pointers are needed, the address of these objects can be given. This removes a small amount of resource handling code in quit().
Use smart pointers instead of raw pointers for the Image class. This removes a small amount of resource handling code in quit().
Avoid calling delete on raw pointers which ButtonImages contains, since these pointers should be managed by smart pointers in GraphicsObjects (in the vector of Image smart pointers).
Use smart pointers instead of raw pointers for the BaseTransition class. This removes a small amount of resource handling code in quit().
Do not delete BaseTransition objects because the raw pointers are now treated as non-owning (the smart pointers in GraphicsObjects actually store the BaseTransition instances).
ThePythonator
force-pushed
the
chore/rework-to-avoid-raw-pointers
branch
from
942511d to
7691724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3. Does not entirely avoid raw pointers - sometimes they are still used in non-owning circumstances, and for holding
BaseStageobjects.This PR means the code now avoids using
newordeletefor anything except creating and destroying stages. The destruction of stages is encapsulated in thecan_delete_meparameter anyway, so memory leaks are less likely.