Prevent recursive thread creation in DllMain#3
Open
rxznve wants to merge 1 commit intoTheEasyPeasy:masterfrom
Open
Prevent recursive thread creation in DllMain#3rxznve wants to merge 1 commit intoTheEasyPeasy:masterfrom
rxznve wants to merge 1 commit intoTheEasyPeasy:masterfrom
Conversation
The previous implementation incorrectly handled all DllMain events (DLL_PROCESS_ATTACH, DLL_THREAD_ATTACH, DLL_THREAD_DETACH, DLL_PROCESS_DETACH) by unconditionally creating a new thread that calls hookSetup. This caused an infinite loop because each new thread triggered a DLL_THREAD_ATTACH event, which in turn created another thread, leading to resource exhaustion and process instability. Fixed by limiting thread creation to the DLL_PROCESS_ATTACH event only, which is the proper place for one-time initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation incorrectly handled all DllMain events (DLL_PROCESS_ATTACH, DLL_THREAD_ATTACH, DLL_THREAD_DETACH, DLL_PROCESS_DETACH) by unconditionally creating a new thread that calls hookSetup.
This caused an infinite loop because each new thread triggered a DLL_THREAD_ATTACH event, which in turn created another thread, leading to resource exhaustion and process instability.
Fixed by limiting thread creation to the DLL_PROCESS_ATTACH event only, which is the proper place for one-time initialization.