Closed
Conversation
- "disable-slots" (bool) - to EntityData and "armorstand" spell effect where it's "true" by default - "disable-slots" (EquipmentSlot enum list) - "equipment-locks" (list of sections with EquipmentSlot "slot" and ArmorStand.LockType "lock")
Other changes: - Added "custom-name" & "custom-name-visibility". - "armorstand" effect options "gravity" and "custom-name-visibility" (now in EntityData) now have expression support.
563a63a to
fb34f2d
Compare
fb34f2d to
dc77afd
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog:
Additions:
disable-slotstoarmorstandspell effect. Boolean, defaulting totrue.minionoption toMinionSpellwhich accepts an Entity Data configuration section. Due to conflicts, ifminionis used,babyhas to be configured within it, not the spell option.armor_stand:disable-slots- Bool or a list of EquipmentSlot.equipment-locks- List of configuration sections with optionsslot(EquipmentSlot) andlock(LockType).custom-name- Rich Textcustom-name-visible,no-physics,persistent,visual-fire, andinvulnerable- Booleanfire-ticksandfreeze-ticks- Integerscoreboard-tags- Aside from a list of strings of tags to add, you can now specify a list of configuration sections withoperation(defaultadd,remove, andclear), andtagto add or remove.passengers- List of Entity Datacan-pickup-items- Booleanmax-health- Doubleaware- Booleanmob-goals:remove-all- Booleanremove-types- List of GoalTyperemove-vanilla- List of VanillaGoalremove- List of Namespaced Keysadd- List of Mob Goal configurationstamed-owner- Boolean - sets the entity as tamed and the recipient as its owner (caster of the spell or target of a Buff).command_minecart:command- Stringfalling_block:cancel-dropandhurt-entities- Booleandamage-per-block- Floatmax-damage- Integerfriction-state-true,false, ornot_setgoat:left-horn,right-horn, andscreaming- Booleanhoglin:immune-to-zombificationandable-to-be-hunted- Booleanitem:item- Vanilla item format or Magic Item Stringmax-speed- Doubleslow-when-empty- Booleandisplay-block-offset- Integerdisplay-block- Block Datapiglin:able-to-hunt- Booleandancing- Integer ticksimmune-to-zombification- Booleanpatrol-leader,can-join-raid, andcelebrating- Booleansalmon:salmon-variant- Salmon Variantvindicator:johnny- Booleanzombie_villager:villager-profession- Villager Professionvillager-type- Villager Type.targeted.EntityDataApplySpellwithentityEntity Data option. This spell applies the configured Entity Data to the targeted entity..targeted.EntityRemoveSpell, which removes non-player entity targets from the world without the death animation.Changes:
SpawnEntitySpell, thegravityof Entity Data is overridden by the spell'sgravity, whether set or left as default).armorstandspell effect optionsgravityandcustom-name-visibilitynow support expressions.Fixes:
MultiSpellwhen usingenable-custom-spell-cast-chance.MinionSpelloptionmob-chancesnot properly accounting for weighted possibly total being> 100.path_tomob goal default speed being too slow.Notes For Reviewers:
Entity "transformer" refers to any setter on a Bukkit entity. Here are the steps taken on spell/effect transformers regarding the Entity Data override fix for places where Entity Data is supported:
SpawnEntitySpell'sremove-mobshould always have priority), it will keep priority over the one in Entity Data and be applied in the post-consumer.silentandaiinentityspell effect).babyinMinionSpellifentityEntity Data is used).