Add division.py with input validation for zero denominator#13916
Open
kelvinwaringa wants to merge 4 commits intoTheAlgorithms:masterfrom
Open
Add division.py with input validation for zero denominator#13916kelvinwaringa wants to merge 4 commits intoTheAlgorithms:masterfrom
kelvinwaringa wants to merge 4 commits intoTheAlgorithms:masterfrom
Conversation
- Create maths/division.py with divide_numbers() function - Add explicit validation for zero denominator - Include comprehensive docstring with examples - Add doctests for various cases including error handling - Follow repository coding standards with type hints Fixes TheAlgorithms#13845
for more information, see https://pre-commit.ci
- Fix E501: Break long line in docstring to stay within 88 chars - Fix W293: Remove trailing whitespace from blank lines
algorithms-keeper
bot
added
the
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
- Rename parameter 'a' to 'numerator' for clarity - Rename parameter 'b' to 'denominator' for clarity - Update all references in function body and docstring
algorithms-keeper
bot
added
tests are failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
maths/division.pyfile with adivide_numbers()function that includes explicit input validation for zero denominators. This addresses issue #13845.Changes
maths/division.pywithdivide_numbers()functionBenefits
Testing
The function includes doctests that cover:
Related Issue
Fixes #13845