➕ Add read params functions (including .json.gz)#74
Draft
francisbarton wants to merge 1 commit intomainfrom
Draft
➕ Add read params functions (including .json.gz)#74francisbarton wants to merge 1 commit intomainfrom
francisbarton wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #58
There are two versions of each function supplied:
azkitread_*functions, which have minimal differences in output compared to the current standard / expected output (eg numeric vectors rather than lists)jsonlitepackage, which have negligible differences in output compared to the current standard / expected output (eg numbers represented as integers rather than doubles)This PR is here as an example of how these functions could be adopted in reskit.
But it is not currently ready to review and merge, because:
a) there are two identically-named versions of each function, so a choice has to be made as to which approach to take
b) it is possible we will move away from ever needing to read in a
.json.gzfile so these will be obsoleteSee also: discussion and background here and here