Skip to content

improves status logic#665

Merged
matt-dray merged 4 commits into
mainfrom
more_v5_fixes
May 19, 2026
Merged

improves status logic#665
matt-dray merged 4 commits into
mainfrom
more_v5_fixes

Conversation

@tomjemmett
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 19, 2026 13:46
@tomjemmett tomjemmett requested a review from a team as a code owner May 19, 2026 13:46
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the client-side polling logic for model run status, aligning it with a res$status-based API response and refining the progress/stage reporting emitted during a run.

Changes:

  • Replaces the old state/detail_status branching with explicit res$status handling (complete, error, submitted, running).
  • Refactors progress “stage” calculation and always emits a standardized progress message.
  • Improves error logging by including the current error counter in the catch handler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/mod_run_model_api_calls.R
Comment thread R/mod_run_model_api_calls.R
Comment thread R/mod_run_model_api_calls.R
Comment thread R/mod_run_model_api_calls.R
Comment thread R/mod_run_model_api_calls.R Outdated
tomjemmett and others added 3 commits May 19, 2026 14:55
Copy link
Copy Markdown
Contributor

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed on a call. Will approve, merge and check it out in the dev deploy.

@matt-dray matt-dray added bug Something isn't working must MoSCoW priority labels May 19, 2026
@matt-dray matt-dray added this to the v5.0.0 milestone May 19, 2026
@matt-dray matt-dray merged commit ea2beda into main May 19, 2026
3 checks passed
@matt-dray matt-dray deleted the more_v5_fixes branch May 19, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working must MoSCoW priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants