Skip to content

replaces the azure logic with {azkit}#658

Merged
tomjemmett merged 3 commits into
mainfrom
use_azkit
May 18, 2026
Merged

replaces the azure logic with {azkit}#658
tomjemmett merged 3 commits into
mainfrom
use_azkit

Conversation

@tomjemmett
Copy link
Copy Markdown
Member

@tomjemmett tomjemmett commented May 18, 2026

replaces the existing logic for getting azure auth tokens with azkit::get_auth_token.

Copilot AI review requested due to automatic review settings May 18, 2026 09:38
@tomjemmett tomjemmett requested a review from a team as a code owner May 18, 2026 09:38
@tomjemmett tomjemmett added enhancement New feature or request could MoSCoW priority labels May 18, 2026
@tomjemmett tomjemmett self-assigned this May 18, 2026
@tomjemmett tomjemmett requested a review from matt-dray May 18, 2026 09:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the package’s Azure Data Lake Storage (ADLS) access to use {azkit} for authentication, removing the previous {AzureAuth}-based token acquisition and simplifying the ADLS filesystem construction.

Changes:

  • Replace managed-identity token acquisition via {AzureAuth} with azkit::get_auth_token() in get_adls_fs().
  • Remove the local/emulator endpoint branch (LOCAL_STORAGE_*) from the ADLS filesystem setup.
  • Update package dependencies to import {azkit} and add its GitHub remote.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
R/fct_azure_storage.R Switch ADLS auth/token handling to {azkit} and simplify endpoint/filesystem creation.
DESCRIPTION Replace {AzureAuth} with {azkit} in Imports and add {azkit} to Remotes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/fct_azure_storage.R
Comment thread R/fct_azure_storage.R Outdated
@tomjemmett
Copy link
Copy Markdown
Member Author

note that this would likely have the same issue we saw in the outputs app, we would need to set the IMDS_AVAILABLE env var on connect to bypass the check for whether a managed token will work or not

@matt-dray matt-dray added this to the v5.0.0 milestone May 18, 2026
@matt-dray
Copy link
Copy Markdown
Contributor

Workflow error; looks like it needs to be redocumented.

Copy link
Copy Markdown
Contributor

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cracking, cheers.

@tomjemmett tomjemmett merged commit 32f4eb7 into main May 18, 2026
3 checks passed
@tomjemmett tomjemmett deleted the use_azkit branch May 18, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

could MoSCoW priority enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants