replaces the azure logic with {azkit}#658
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the package’s Azure Data Lake Storage (ADLS) access to use {azkit} for authentication, removing the previous {AzureAuth}-based token acquisition and simplifying the ADLS filesystem construction.
Changes:
- Replace managed-identity token acquisition via
{AzureAuth}withazkit::get_auth_token()inget_adls_fs(). - Remove the local/emulator endpoint branch (LOCAL_STORAGE_*) from the ADLS filesystem setup.
- Update package dependencies to import
{azkit}and add its GitHub remote.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| R/fct_azure_storage.R | Switch ADLS auth/token handling to {azkit} and simplify endpoint/filesystem creation. |
| DESCRIPTION | Replace {AzureAuth} with {azkit} in Imports and add {azkit} to Remotes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
note that this would likely have the same issue we saw in the outputs app, we would need to set the IMDS_AVAILABLE env var on connect to bypass the check for whether a managed token will work or not |
Contributor
|
Workflow error; looks like it needs to be redocumented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces the existing logic for getting azure auth tokens with
azkit::get_auth_token.