Skip to content

grt: replace assert with logger error in CUGR maze route #9870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eder-matheus merged 7 commits into from
Mar 25, 2026
Merged

grt: replace assert with logger error in CUGR maze route #9870

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f459c06
grt: replace assert with logger error in CUGR maze route
Divinesoumyadip Mar 21, 2026
8629f29
grt: use warn and continue instead of error for null Steiner tree
Divinesoumyadip Mar 21, 2026
662ca39
grt: clang-format
Divinesoumyadip Mar 21, 2026
6adb83f
grt: revert to logger error for null Steiner tree per Eder's feedback
Divinesoumyadip Mar 23, 2026
c25a3bf
grt: restore continue for nets with fewer than 2 pins in mazeRoute
Divinesoumyadip Mar 24, 2026
9b5b030
grt: restore all continue statements for nets with fewer than 2 pins
Divinesoumyadip Mar 24, 2026
1e74f46
grt: restore continue for routing_tree and db_layer checks
Divinesoumyadip Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/grt/src/cugr/src/CUGR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#include "CUGR.h"

#include <algorithm>
#include <cassert>
#include <cmath>
#include <cstddef>
#include <cstdint>
Expand Down Expand Up @@ -229,7 +228,12 @@ void CUGR::mazeRoute(std::vector<int>& net_indices)
maze_route.constructSparsifiedGraph(wire_cost_view, grid);
maze_route.run();
std::shared_ptr<SteinerTreeNode> tree = maze_route.getSteinerTree();
assert(tree != nullptr);
if (tree == nullptr) {
logger_->error(GRT,
610,
"Failed to generate Steiner tree for net {}.",
net->getName());
}
Comment thread
eder-matheus marked this conversation as resolved.

PatternRoute pattern_route(
net, grid_graph_.get(), stt_builder_, constants_, logger_);
Expand Down Expand Up @@ -414,7 +418,12 @@ void CUGR::getGuides(const GRNet* net,
};

// 1. Pin access patches
assert(constants_.min_routing_layer + 1 < grid_graph_->getNumLayers());
if (constants_.min_routing_layer + 1 >= grid_graph_->getNumLayers()) {
logger_->error(GRT,
611,
"Min routing layer {} exceeds available layers.",
constants_.min_routing_layer);
}
for (auto& gpts : net->getPinAccessPoints()) {
for (auto& gpt : gpts) {
if (gpt.getLayerIdx() < constants_.min_routing_layer) {
Expand Down
Loading