dpl: map fillers by site#9861
dpl: map fillers by site#9861openroad-ci wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@eder-matheus what happens if the same site appears in both the techlef and the stdlef (it used to be ODB would end up with two site definitions and different tools handle that differently unfortunately) |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request refactors the dpl code to map filler cells by site instead of height, improving the logic for filler cell placement. The changes involve modifying data structures and function parameters to use odb::dbSite* for site information. The code also checks both site and site height to ensure the correct filler cell is used. Overall, this seems like a good refactoring that should improve the accuracy of filler cell placement.
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
3 participants
Summary
Instead of mapping filler cells by their height, use their sites. Additionally, check both site and site height to ensure the correct filler cell is used to fill a gap.
Type of Change
Impact
No impact, since it's mainly a refactoring,
Verification
./etc/Build.sh).Related Issues
Fixes https://github.com/The-OpenROAD-Project-private/OpenROAD-flow-scripts/issues/1574