Conversation
only create instances toggle if debug mode is active, draw charts when gui is active Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the graphics initialization and update logic within the GPL module. Key changes include extracting chart initialization into a dedicated initCharts() method, making the routing_chart_ conditional on routability_driven_mode, and renaming initHeatmap() to initDebugHeatmap(). Debug-specific graphics setup, such as adding display controls and instance selection, is now explicitly gated by a debug_on_ flag and the presence of a debug_inst parameter. Additionally, the updateIterGraphics function was refined to ensure iteration data is always added if graphics are available, while more resource-intensive debug updates are strictly controlled by the npVars_.debug flag.
|
clang-tidy review says "All clean, LGTM! 👍" |
| density_chart_->setXAxisFormat("%d"); | ||
| density_chart_->setYAxisFormats({"%.2e", "%.2f"}); | ||
| density_chart_->setYAxisMin({0.0, nbc_->getNbVars().minPhiCoef}); | ||
| initCharts(); |
There was a problem hiding this comment.
should this be conditional on debugging?
There was a problem hiding this comment.
I chose it not to be. Do you think it should? Either way, when we do make gui_... we do not see the GPL charts. Currently it only works if we run GPL itself with gui active (for example running an run-me artifact).
I realized the main chart was being created twice, I fixed that on the last commit.
There was a problem hiding this comment.
If you with the gui active but no debug enabled you shouldn't see the chart (which will be empty afaik).
There was a problem hiding this comment.
so having the debug fence for initCharts() should only make a difference when running the artifact. As it is currently we can execute the run-me and get the charts without requiring the debug command. Do you think it should be initialized only when in debug mode?
Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
2 participants
Only show GUI toggle for GPL debug instances drawings if GPL debug mode is active.
Some other reorganization for debug mode and GPL charts.