Remove not needed system header includes. #9090
Conversation
Head branch was pushed to by a user without write access
hzeller
force-pushed
the
feature-20251218-remove-unneeded-sys-hdrs
branch
2 times, most recently
from
bac4319 to
3dc020b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include "SACoreSoftMacro.h" | ||
| #include "SimulatedAnnealingCore.h" | ||
| #include "boost/polygon/polygon.hpp" | ||
| #include "clusterEngine.h" |
There was a problem hiding this comment.
warning: included header polygon.hpp is not used directly [misc-include-cleaner]
| #include "clusterEngine.h" | |
| #include "clusterEngine.h" |
There was a problem hiding this comment.
Header is used, but they don't have the correct annotations ( which I attempt to fix upstream boostorg/polygon#98 ).
hzeller
force-pushed
the
feature-20251218-remove-unneeded-sys-hdrs
branch
from
3dc020b to
87ef3ad
Compare
|
approved in concept; will merge when the CI passes |
Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20251218-remove-unneeded-sys-hdrs
branch
from
87ef3ad to
e24666b
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
is the CI failure something from the change or just a CI glitch ? |
|
real failures, eg https://jenkins.openroad.tools/job/OpenROAD-Public/job/PR-9090-head/5/pipeline-overview/log?nodeId=264 [2025-12-23T10:42:35.773Z] #9 119.0 /OpenROAD/src/gui/src/dbDescriptors.cpp:1313:8: error: ‘priority_queue’ is not a member of ‘std’ |
|
ok, I think for now let's abandon this. We should first add all missing headers before we remove some. clang-tidy gets confused with that. |
2 participants
No description provided.