rsz: skip ensureWireParasitic in repair_design hot path#10507
Open
minjukim55 wants to merge 1 commit into
Open
rsz: skip ensureWireParasitic in repair_design hot path#10507minjukim55 wants to merge 1 commit into
minjukim55 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an optional load_cap_hint parameter to resizeToTargetSlew and makeRepeater to optimize performance by skipping incremental FastRoute calls during global routing. A review comment suggests addressing implicit type conversions and truncation issues when calculating buffer_load_cap in RepairDesign.cc by using explicit casting and direct double arithmetic.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome to OpenROAD! Thanks for opening your first PR.
Before we review:
- Contribution Guide: https://openroad.readthedocs.io/en/latest/contrib/contributing.html
- Build Instructions: https://openroad.readthedocs.io/en/latest/contrib/BuildWithCMake.html
Please ensure:
- CI passes
- Code is properly formatted
- Tests are included where applicable
A maintainer will review shortly!
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
minjukim55
force-pushed
the
secure-rsz-issue1676-v2
branch
from
e5fcad7 to
217bf3b
Compare
Pass a local load_cap computed from BufferedNet wire RC to resizeToTargetSlew as a hint. When supplied, the hint skips the expensive ensureWireParasitic + STA loadCap query that triggers an incremental FastRoute setup per buffer in the repair_design driver loop. For repairNetWire, the hint reflects the wire that the buffer actually drives (buf_dist x wire_cap + ref_cap), not the full Steiner edge. repairNetJunc passes cap_left / cap_right since the buffer is placed at the junction location. Profiling on a large customer design (497k inst) showed ensureWireParasitic accounting for 96% of repair_design wall time (5,860 calls x ~390ms FastRoute setup each). See private issue The-OpenROAD-Project-private/OpenROAD-flow-scripts#1676. Signed-off-by: Minju Kim <mkim@precisioninno.com>
minjukim55
force-pushed
the
secure-rsz-issue1676-v2
branch
from
217bf3b to
dbdd58f
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type
Impact
Profiled on a large customer design (497k inst) where `ensureWireParasitic` accounted for 96% of `repair_design` wall time (5,860 calls × ~390ms FastRoute setup each).
Measured on the same design (same cts.odb, same OR commit, 5_1_grt step only re-run):
Verification
Related Issues
See private issue The-OpenROAD-Project-private/OpenROAD-flow-scripts#1676.
(Note: supersedes #3433 which had its head branch renamed.)