bazel: reinstate ditch-docker via archive_override for orfs#10334
Conversation
Reinstates The-OpenROAD-Project#10237 (reverted in The-OpenROAD-Project#10333) with one change: the orfs module override switches from git_override to archive_override so PII machines that block direct git access to github.com (but allow HTTPS tarball downloads) can resolve the module graph without going through the docker image. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
@hzeller @maliberty This should sort out the concern that ORFS public git repo is not available from inside PII: use source tar.gz instead. |
| ORFS_COMMIT = "10a2baea2171059ec14cda9a5855aa26dd7572c6" | ||
|
|
||
| bazel_dep(name = "orfs", dev_dependency = True) | ||
| archive_override( |
There was a problem hiding this comment.
avoids git protocol for ORFS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the bazel-orfs dependency and introduces an archive_override for the orfs module to ensure compatibility in environments with restricted git access. It also adds yosys and yosys-slang dependencies, configures the slang.so plugin, and includes a patch to strip root-only overrides from the orfs module. In the mock-array test, ARRAY_COLS and ARRAY_ROWS are moved to user_arguments. I have no feedback to provide.
|
@vvbandeira Not a problem, just a heads up... 1 hr for clang-tidy 😺 
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@hzeller Looks good? |
2 participants
Reinstates #10237 (reverted in #10333) with one change: the
orfsmodule override switches fromgit_overridetoarchive_overrideso PII machines that block direct git access togithub.com(but allow HTTPS tarball downloads) can resolve the module graph without going through the docker image.The other overrides introduced by #10237 (
bazel-orfs,bazel-orfs-verilog,yosys-slang) stay ongit_override—yosys-slangneedsinit_submodules, and tarball-aware bumping support forbazel-orfsis being added separately.cc @maliberty — feel free to push fixups to this branch.
Test plan
bazelisk mod depsresolves cleanly without git access togithub.com/The-OpenROAD-Project/OpenROAD-flow-scripts.gitbazelisk build //...fromtools/OpenROAD/bazelisk test //test/orfs/mock-array/...