sta: expose the dbMod* in tcl#10316
Open
gadfort wants to merge 5 commits intoThe-OpenROAD-Project:masterfrom
Open
sta: expose the dbMod* in tcl#10316gadfort wants to merge 5 commits intoThe-OpenROAD-Project:masterfrom
gadfort wants to merge 5 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several functions to convert STA instances, ports, pins, and nets to their database module equivalents and updates the SWIG container wrappers. The review feedback highlights a bug in the sta_to_db_port implementation regarding top-level port handling and suggests simplifying the implementation of several functions by utilizing existing dbNetwork helper methods such as flatPin, hierPin, and flatNet.
Signed-off-by: Peter Gadfort <peter.gadfort@gmail.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
2 similar comments
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add access to the dbMod* objects in dbSta and associated containers
Type of Change
Impact
No, change just more helper methods
Verification
./etc/Build.sh).Related Issues