[RSZ] Make getSwappableCells, getVTEquivCells, and replaceCell public.#10304
Open
Logikable wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Open
[RSZ] Make getSwappableCells, getVTEquivCells, and replaceCell public.#10304Logikable wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Logikable wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Sean Luchen <seanluchen@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
|
Those functions are swig bound by default @Logikable. Could we potentially move them into their own file and bazel target to correctly limit visibility and prevent inadvertent SWIG capture? |
Signed-off-by: Sean Luchen <seanluchen@google.com>
Contributor
Author
I've added ignores to the Python SWIG, which appears to be the standard practice. How does this look? |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.