Skip to content

Update metrics grt incremental fix#4272

Open
jfgava wants to merge 4 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_metrics-grt-incremental-fix
Open

Update metrics grt incremental fix#4272
jfgava wants to merge 4 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_metrics-grt-incremental-fix

Conversation

@jfgava
Copy link
Copy Markdown
Contributor

@jfgava jfgava commented Jun 2, 2026

GRT results are fine. Some designs had a degradation in post-DRT stage (e.g., asap7 riscv32i-mock-sram).
Related to this PR

designs/nangate45/aes/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -0.673 -0.671 Tighten
globalroute__timing__hold__tns -0.726 -0.624 Tighten
finish__timing__setup__tns -0.167 -0.339 Failing

designs/nangate45/ariane133/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -577.0 -576.0 Tighten
finish__timing__setup__tns -576.0 -585.0 Failing

designs/nangate45/bp_be_top/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -19.1 -20.0 Failing

designs/nangate45/bp_fe_top/rules-base.json updates:

Metric Old New Type
finish__timing__setup__tns -1.23 -1.8 Failing

designs/sky130hd/chameleon/rules-base.json updates:

Metric Old New Type
globalroute__antenna_diodes_count 196 200 Failing
globalroute__timing__setup__ws -0.944 -0.943 Tighten

designs/sky130hd/gcd/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -88.8 -89.0 Failing
finish__timing__setup__ws -1.85 -1.82 Tighten
finish__timing__setup__tns -87.6 -85.7 Tighten

designs/sky130hs/ibex/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -23.4 -43.4 Failing

designs/sky130hd/jpeg/rules-base.json updates:

Metric Old New Type
globalroute__antenna_diodes_count 100 102 Failing
globalroute__timing__setup__ws -0.764 -0.754 Tighten
globalroute__timing__setup__tns -111.0 -113.0 Failing
finish__timing__setup__tns -42.9 -42.2 Tighten

designs/ihp-sg13g2/jpeg/rules-base.json updates:

Metric Old New Type
detailedroute__antenna_diodes_count 109 120 Failing

designs/sky130hd/microwatt/rules-base.json updates:

Metric Old New Type
globalroute__antenna_diodes_count 1333 1364 Failing
globalroute__timing__setup__tns -345.0 -306.0 Tighten
detailedroute__antenna_diodes_count 1434 1281 Tighten
finish__timing__setup__ws -2.7 -2.65 Tighten
finish__timing__setup__tns -360.0 -306.0 Tighten
finish__timing__hold__ws -1.0 -0.964 Tighten
finish__timing__hold__tns -6.71 -6.38 Tighten

designs/sky130hd/riscv32i/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -300.0 -304.0 Failing

designs/sky130hs/riscv32i/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -134.0 -142.0 Failing
detailedroute__route__wirelength 346876 346646 Tighten
finish__timing__setup__tns -20.9 -29.2 Failing

designs/asap7/riscv32i-mock-sram/rules-base.json updates:

Metric Old New Type
synth__canonical_netlist__hash 855cc88198fc9faaf17317eaea4a3a07a4340d1d 8b6a7c8c51339babf0f00aeb44dd4b65ab30b183 Failing
detailedroute__route__wirelength 64313 63228 Tighten
finish__timing__setup__tns -230.0 -1720.0 Failing

designs/nangate45/swerv/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -485.0 -502.0 Failing
detailedroute__route__wirelength 2366013 2365053 Tighten
finish__timing__setup__tns -479.0 -609.0 Failing
finish__design__instance__area 183688 183574 Tighten

designs/nangate45/swerv_wrapper/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__ws -0.345 -0.34 Tighten
globalroute__timing__setup__tns -146.0 -157.0 Failing
finish__timing__setup__tns -126.0 -142.0 Failing

designs/gf12/gcd/rules-base.json updates:

Metric Old New Type
globalroute__timing__setup__tns -133.0 -210.0 Failing

jfgava added 4 commits June 2, 2026 18:07
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
Signed-off-by: Jonas Gava <jfgava@precisioninno.com>
@jfgava jfgava self-assigned this Jun 2, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenROAD submodule to a newer commit and adjusts the regression baseline metrics across multiple designs. The review feedback highlights several significant timing degradations (setup TNS) in the updated baselines, specifically for riscv32i-mock-sram, ibex, swerv, and gcd. It is requested that tracking issues or explicit agreements be referenced to address these degradations post-merge.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread flow/designs/asap7/riscv32i-mock-sram/rules-base.json
Comment thread flow/designs/sky130hs/ibex/rules-base.json
Comment thread flow/designs/nangate45/swerv/rules-base.json
Comment thread flow/designs/gf12/gcd/rules-base.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant